Skip to content

Commit 318e644

Browse files
committed
rename Unity WebGL plugin files to avoid name collisions
Unity flattens WebGL plugins into a single output directory, so the generic WebSocket.jslib name collided with identically named plugins from other packages (Photon ships one), failing the build with "Plugin 'WebSocket.jslib' is used from several locations". Only the file names change -- the exported JavaScript symbols are unchanged and nothing references these files by name. Thanks to @Alaadel for the report. Assisted-by: Claude Opus 4.8
1 parent 49643be commit 318e644

3 files changed

Lines changed: 4 additions & 4 deletions

File tree

.github/workflows/unity-upm-release.yml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -49,8 +49,8 @@ jobs:
4949
# Unity-specific files (WebGL platform support)
5050
cp integrations/Unity/WebSocketWebGL.cs upm-package/WebSocket/
5151
cp integrations/Unity/WebSocketFactoryWebGL.cs upm-package/WebSocket/
52-
cp integrations/Unity/WebSocket.jslib upm-package/WebSocket/
53-
cp integrations/Unity/WebSocket.jspre upm-package/WebSocket/
52+
cp integrations/Unity/NativeWebSocket.jslib upm-package/WebSocket/
53+
cp integrations/Unity/NativeWebSocket.jspre upm-package/WebSocket/
5454
cp integrations/Unity/colyseus.nativewebsocket.asmdef upm-package/WebSocket/
5555
5656
# Package metadata and samples
@@ -190,8 +190,8 @@ jobs:
190190
# Unity-specific files
191191
cp integrations/Unity/WebSocketWebGL.cs upm-package/Assets/WebSocket/
192192
cp integrations/Unity/WebSocketFactoryWebGL.cs upm-package/Assets/WebSocket/
193-
cp integrations/Unity/WebSocket.jslib upm-package/Assets/WebSocket/
194-
cp integrations/Unity/WebSocket.jspre upm-package/Assets/WebSocket/
193+
cp integrations/Unity/NativeWebSocket.jslib upm-package/Assets/WebSocket/
194+
cp integrations/Unity/NativeWebSocket.jspre upm-package/Assets/WebSocket/
195195
cp integrations/Unity/colyseus.nativewebsocket.asmdef upm-package/Assets/WebSocket/
196196
197197
# Package metadata

0 commit comments

Comments
 (0)