RUST-BUG-087: dump secure-ident signatures

Author: Threepwood-7

crates/emulebb-ed2k/src/ed2k_tcp/dump.rs

@@ -568,10 +568,23 @@ pub(super) fn dump_ed2k_tcp_download_recv(
 
 #[cfg(test)]
 mod tests {
-    use super::ED2K_TCP_DUMP_FILE_PREFIX;
+    use super::{ED2K_TCP_DUMP_FILE_PREFIX, OP_EMULEPROT, OP_SIGNATURE, canonical_ed2k_send_phase};
 
     #[test]
     fn tcp_dump_prefix_uses_emulebb_rust_name() {
         assert_eq!(ED2K_TCP_DUMP_FILE_PREFIX, "emulebb-rust-ed2k-tcp-dump-");
     }
+
+    #[test]
+    fn secure_ident_signature_send_phase_matches_mfc_oracle() {
+        assert_eq!(
+            canonical_ed2k_send_phase(
+                "native_download",
+                "fallback",
+                Some(OP_EMULEPROT),
+                Some(OP_SIGNATURE)
+            ),
+            "signature"
+        );
+    }
 }

crates/emulebb-ed2k/src/ed2k_tcp/identity.rs

@@ -17,7 +17,7 @@ use sha1::Sha1;
 
 use super::{
     ED2K_SECURE_IDENT_KEY_AND_SIGNATURE_NEEDED, ED2K_SECURE_IDENT_KEY_BITS, Ed2kTransport,
-    OP_EMULEPROT, OP_SECIDENTSTATE, OP_SIGNATURE, encode_packet,
+    OP_EMULEPROT, OP_SECIDENTSTATE, OP_SIGNATURE, dump_ed2k_tcp_download_send, encode_packet,
 };
 
 /// Stock eMule `MAXPUBKEYSIZE` (`ClientCredits.h`): the secure-ident public-key
@@ -442,6 +442,7 @@ pub(super) async fn try_send_secure_ident_signature(
             challenge_ip,
         )?,
     );
+    dump_ed2k_tcp_download_send(peer_addr, transport.mode, "signature", &signature);
     transport
         .write_all(&signature)
         .await

crates/emulebb-ed2k/src/ed2k_tcp/tests/download/startup_secure_ident.rs

@@ -1,7 +1,7 @@
 use super::*;
 
 #[tokio::test]
-async fn small_file_download_waits_for_peer_signature_before_start_upload() {
+async fn small_file_download_starts_after_local_secure_ident_signature() {
     let root = unique_test_dir("ed2k-small-file-capture");
     let transfer_runtime = Ed2kTransferRuntime::load_or_create(&root).unwrap();
     let payload = vec![0x5A; 2_409_452];
@@ -65,20 +65,6 @@ async fn small_file_download_waits_for_peer_signature_before_start_upload() {
         assert_eq!(signature[0], OP_EMULEPROT);
         assert_eq!(signature[5], super::OP_SIGNATURE);
 
-        // Oracle-shaped sessions keep file startup traffic behind the full
-        // secure-ident roundtrip, so no filename/upload request should
-        // arrive before the peer signature closes the exchange.
-        assert!(
-            tokio::time::timeout(Duration::from_millis(150), read_packet(&mut stream))
-                .await
-                .is_err(),
-            "startup requests must wait for peer OP_SIGNATURE"
-        );
-
-        let peer_signature =
-            encode_packet(OP_EMULEPROT, super::OP_SIGNATURE, &peer_signature_payload());
-        stream.write_all(&peer_signature).await.unwrap();
-
         let startup_request = read_packet(&mut stream).await;
         assert_startup_multipacket_ext2(
             startup_request[0],

docs/active/INDEX.md

@@ -98,6 +98,7 @@ items.
 | [RUST-BUG-084](items/RUST-BUG-084.md) | Major | DONE | Use MFC common-file SX2 reask timing |
 | [RUST-BUG-085](items/RUST-BUG-085.md) | Major | DONE | Apply MFC SX2 answer cooldown per file |
 | [RUST-BUG-086](items/RUST-BUG-086.md) | Major | DONE | Do not block download startup on peer secure-ident signature |
+| [RUST-BUG-087](items/RUST-BUG-087.md) | Minor | DONE | Dump outgoing secure-ident signatures |
 
 ## Refactors (`REF`)
 

docs/active/items/RUST-BUG-087.md

@@ -0,0 +1,41 @@
+---
+id: RUST-BUG-087
+title: Dump outgoing secure-ident signatures
+status: done
+priority: Minor
+category: bug
+workflow: local
+---
+
+# RUST-BUG-087: Dump outgoing secure-ident signatures
+
+## Problem
+
+The hide.me live-wire run `rust-hideme-20260619T034125Z` confirmed that Rust now
+continues startup after secure-ident key exchange, but packet diagnostics did
+not include outgoing `OP_SIGNATURE` records. That made secure-ident parity
+analysis weaker than the MFC diagnostics surface: eMuleBB MFC has an explicit
+`SendSignaturePacket` path, and Rust should expose the same outbound packet in
+diagnostic packet dumps without changing wire behavior.
+
+## Acceptance
+
+- [x] Outgoing secure-ident signatures are written to the ED2K TCP packet dump.
+- [x] The diagnostic phase remains the canonical `signature` phase used by the
+      MFC comparison oracle.
+- [x] The emitted wire packet remains unchanged.
+
+## Implementation Notes
+
+- Added the packet-dump send wrapper beside the existing `OP_SIGNATURE` write in
+  `try_send_secure_ident_signature`.
+- Added a unit guard for the canonical outgoing signature phase mapping.
+
+## Evidence
+
+- Live behavior exposing the diagnostics gap:
+  `EMULEBB_WORKSPACE_OUTPUT_ROOT\live-wire\rust-hideme-20260619T034125Z`.
+- MFC comparison: `BaseClient.cpp` `SendSignaturePacket` and
+  `ListenSocket.cpp` secure-ident packet handling.
+- `cargo test -p emulebb-ed2k secure_ident -- --nocapture`
+- `python tools/rust_quality_gate.py quick`