Skip to content

[AUD-018][High] Package numerical-toolbox content in CPack artifacts #313

Description

@gabrielsantosphilips

Audit finding

  • ID: AUD-018
  • Status: Verified defect
  • Severity: High
  • Confidence: High
  • Audited revision: 2f479320d805a1f9f35ebe4afaaeeded48913a94

Problem

The CI package target and upload succeed, but generated ZIP/TGZ archives contain only 13 pugixml entries. There are no numerical-toolbox headers, libraries, or exported CMake targets because the first-party CMake tree defines no install() rules.

Sources:

  • endif()
    emil_coverage_targets(DIRECTORIES .)
    if (NUMERICAL_TOOLBOX_STANDALONE)
    emil_folderize_all_targets()
    endif()
    set(CPACK_GENERATOR "ZIP;TGZ")
    set(CPACK_SOURCE_IGNORE_FILES ".vs/;.git/;build/")
    set(CPACK_PACKAGE_NAME "${PROJECT_NAME}")
    set(CPACK_PACKAGE_VERSION "${PROJECT_VERSION}")
    set(CPACK_PACKAGE_DESCRIPTION "${PROJECT_DESCRIPTION}")
    set(CPACK_DEBIAN_PACKAGE_NAME "${CPACK_PACKAGE_NAME}")
    set(CPACK_RPM_PACKAGE_NAME "${CPACK_PACKAGE_NAME}")
    set(CPACK_PACKAGE_HOMEPAGE_URL "${PROJECT_HOMEPAGE_URL}")
  • - uses: lukka/run-cmake@5d55ea7949e25f69f0ecb516d8d572297e03a956 # v10.9
    with:
    configurePreset: "host"
    buildPreset: "host-Debug-WithPackage"
    testPreset: "host"
    configurePresetAdditionalArgs: "['-DCMAKE_C_COMPILER_LAUNCHER=ccache', '-DCMAKE_CXX_COMPILER_LAUNCHER=ccache']"
    - uses: actions/upload-artifact@043fb46d1a93c77aae656e7c1c64a875d1fc6a0a # v7.0.1
    with:
    name: numerical-toolbox
    path: build/host/numerical-toolbox-*-Linux.tar.gz
    if-no-files-found: error

Acceptance criteria

  • Install public numerical headers and exported CMake targets.
  • Package metadata identifies numerical-toolbox and its dependencies correctly.
  • CI inspects archive contents before upload.
  • A clean downstream project can consume the archive via the documented mechanism.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions