fix sonar findings

Author: gabrielfrasantos

numerical/analysis/CMakeLists.txt

@@ -25,7 +25,6 @@ target_sources(numerical.analysis PRIVATE
 
 numerical_add_coverage_sources(numerical.analysis
     ConvolutionCorrelation.cpp
-    Decibels.cpp
     FastFourierTransformRadix2Impl.cpp
     GoertzelAlgorithm.cpp
     PowerDensitySpectrum.cpp

numerical/analysis/Decibels.cpp

@@ -47,11 +47,4 @@ namespace analysis
         static_assert(std::is_floating_point_v<T>, "RippleDb supports floating-point types only");
         return ToDecibels(maxRatio) - ToDecibels(minRatio);
     }
-
-#ifdef NUMERICAL_TOOLBOX_COVERAGE_BUILD
-    extern template float ToDecibels<float>(float);
-    extern template float FromDecibels<float>(float);
-    extern template float AttenuationDb<float>(float, float);
-    extern template float RippleDb<float>(float, float);
-#endif
 }

numerical/analysis/Decibels.hpp

@@ -35,7 +35,6 @@ numerical_add_coverage_sources(numerical.math
     Matrix.cpp
     QNumber.cpp
     Quaternion.cpp
-    StepResponseMetrics.cpp
 )
 
 add_subdirectory(test)

numerical/math/CMakeLists.txt

@@ -18,8 +18,8 @@ namespace math
     {
         static_assert(std::is_floating_point_v<T>, "RiseTime supports floating-point types only");
 
-        const T lo{ T{ 0.1 } * steady };
-        const T hi{ T{ 0.9 } * steady };
+        const T lo{ T{ 0.1f } * steady };
+        const T hi{ T{ 0.9f } * steady };
 
         std::size_t iLo{ 0 };
         bool foundLo{ false };
@@ -40,7 +40,7 @@ namespace math
     }
 
     template<typename T, std::size_t Size>
-    [[nodiscard]] OPTIMIZE_FOR_SPEED T SettlingTime(const Vector<T, Size>& response, T steady, T band = T{ 0.02 }, T dt = T{ 1 })
+    [[nodiscard]] OPTIMIZE_FOR_SPEED T SettlingTime(const Vector<T, Size>& response, T steady, T band = T{ 0.02f }, T dt = T{ 1 })
     {
         static_assert(std::is_floating_point_v<T>, "SettlingTime supports floating-point types only");
 
@@ -113,12 +113,4 @@ namespace math
         const T tailMean{ sum / static_cast<T>(TailSize) };
         return reference - tailMean;
     }
-
-#ifdef NUMERICAL_TOOLBOX_COVERAGE_BUILD
-    extern template float RiseTime<float, 64>(const Vector<float, 64>&, float, float);
-    extern template float SettlingTime<float, 64>(const Vector<float, 64>&, float, float, float);
-    extern template float PercentOvershoot<float, 64>(const Vector<float, 64>&, float);
-    extern template float PeakTime<float, 64>(const Vector<float, 64>&, float);
-    extern template float SteadyStateError<float, 64>(const Vector<float, 64>&, float);
-#endif
 }