Skip to content

Commit 82307cd

Browse files
Apply suggestions from code review
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
1 parent 6fdfd61 commit 82307cd

2 files changed

Lines changed: 6 additions & 6 deletions

File tree

doc/filters/passive/BiquadCascade.md

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -63,11 +63,11 @@ arbitrary biquad — and requires no intermediate storage beyond $z_1$ and $z_2$
6363

6464
## Complexity Analysis
6565

66-
| Case | Time | Space | Notes |
67-
|------------|---------------|---------------|------------------------------------------------|
68-
| Per sample | $O(S)$ | $O(S)$ | $S$ = number of sections; 5 mults + 4 adds each |
69-
| Design | $O(1)$ | $O(1)$ | Closed-form RBJ formulas; no iteration |
70-
| Reset | $O(S)$ | | Zero two state words per section |
66+
| Case | Time | Space | Notes |
67+
|------------|--------|--------|-------------------------------------------------|
68+
| Per sample | $O(S)$ | $O(S)$ | $S$ = number of sections; 5 mults + 4 adds each |
69+
| Design | $O(1)$ | $O(1)$ | Closed-form RBJ formulas; no iteration |
70+
| Reset | $O(S)$ || Zero two state words per section |
7171

7272
## Step-by-Step Walkthrough
7373

numerical/filters/passive/test/TestBiquadCascade.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -111,6 +111,6 @@ TEST_F(TestBiquadCascade, reset_clears_state)
111111

112112
EXPECT_NEAR(filter.Filter(1.0f),
113113
filters::passive::Biquad<float>::LowPass(fc, fs, Q).b0 *
114-
filters::passive::Biquad<float>::LowPass(fc, fs, Q).b0,
114+
filters::passive::Biquad<float>::LowPass(fc, fs, Q).b0,
115115
1e-5f);
116116
}

0 commit comments

Comments
 (0)