Not work on Windows

[sunfkny]

Hi, this commit breaks Windows support: 5ba8618

On Windows, the path separator \ causes two issues:

• indexHTML does not work
• Routes do not match because generated paths contain \

This issue also breaks https://github.com/SaltyAom/elysia-fullstack-example on Windows

[touhidurrr]

more specifically I would say that nothing works on windows (and possibly on linux also, did not test). they broke this plugin again completely. @SaltyAom

[touhidurrr]

Also #51

[lilhuy0405]

On ubuntu it work using "@elysiajs/static": "^1.4.2" but yes on windows seems like nothing can be served in static path even i tried to use const publicPath = resolve(__dirname, '../public') to by pass / and \ separator for both linux and windows
p/s: I tried degrade to 1.3.0 then it can serve the index.html file but can not bundle/compile the jsx maybe bun problem on window not sure :)))

[SaltyAom]

Possibly fix #52

[sunfkny]

Possibly fix #52

This still doesn’t match on Windows, so there is an extra '/' before the path.

elysia-static/src/index.ts

Line 55 in a6dc9bf

if (prefix === path.sep) prefix = '' as Prefix

With this config
https://github.com/SaltyAom/elysia-fullstack-example/blob/7e4edf6b34f27641ba4408a40bbdf4c88878e14d/src/index.ts#L12-L14

I can only access via
http://localhost:3000//images/maddelena-1.webp
instead of
http://localhost:3000/images/maddelena-1.webp.

[touhidurrr]

I have already said that using backslash is a recipe for disaster. Why use backslash since windows supports / anyways. Time and time we see bugs that affect windows. This is frustrating.

[SaltyAom]

Can you try updating to 1.4.5 to see if it fix your problem

[touhidurrr]

Can you try updating to 1.4.5 to see if it fix your problem

As specified before in my PR, 1.4.5 does not solve this issue. I will try to post a repro when I have time.

[elliotchun]

1.4.7 seems to have fixed the plugin on Windows. Tested using https://github.com/SaltyAom/elysia-fullstack-example

[touhidurrr]

1.4.7 seems to have fixed the plugin on Windows. Tested using https://github.com/SaltyAom/elysia-fullstack-example

It did not fix anything, still broken. still using 1.4.0.

[touhidurrr]

Ok, I can confirm that 1.4.7 works. However, my tests were failing because it seems that this is actually a breaking change. So, what did I need to do to fix things?

So, basically 1.4.7 uses the Bun Bundler and thus it expects every resource used to be a relative path. Sigh.

@SaltyAom you can close this now. Can kindly invent some mechanism by which we can know when some new version of your packages is a breaking change. I already treat every minor version of elysia packages as a major one. Now do I even need to consider patch releases as major versions? sigh.

[alexnederlof]

Still doesn't work for me because I can't change the pats. I use Nextjs to build, and it create absolute paths.

[touhidurrr]

Still doesn't work for me because I can't change the pats. I use Nextjs to build, and it create absolute paths.

@alexnederlof maybe try assetPrefix