Does not accept atom keys for pagination option

[4141done]

Hello,

We're using the Params package to handle converting parameters into atom keys. This has been really great as it allows all of our methods handling business logic to expect atom keys. Unfortunately the kerosene package is causing us to have to pass through raw params for routes that require pagination. Would you be open to a PR allowing either string or atom keys for the pagination options?

Thanks,

Javier

[allyraza]

you can do that already send params with options, try sending it as part of the options here is an example

 <%= paginate @conn, @page, params: %{"foo": "bar"}, window: 5, next_label: ">>", previous_label: "<<", first: true, last: true, first_label: "First", last_label: "Last" %>

Thank you

[4141done]

Thank you for the response. Sorry, I should have been more clear. I'm using Repo.paginate and I am finding that while indeed I can specify atom keys for opt, they are overwritten by nil values from params by merge_options/2. I understand that this is desired behavior since you'd like you use opts to set global options that can be overridden on a per-request basis.

The two lines that are causing me issue are in https://github.com/elixirdrops/kerosene/blob/master/lib/kerosene.ex:120

    page = Map.get(params, "page", 1)
    per_page = Map.get(params, "per_page", opts[:per_page])

I'll probably just submit the PR and you can decide then

[allyraza]

I am open to suggestions and improvements, please go ahead and do a PR, in the meantime I will also ponder on this.

cheers

[mtarnovan]

I encountered this too. I would suggest stringifying params beforehand.

    def stringify_keys(nil), do: nil

    def stringify_keys(map = %{}) do
      map
      |> Enum.map(fn {k, v} -> {Atom.to_string(k), stringify_keys(v)} end)
      |> Enum.into(%{})
    end

    def stringify_keys([head | rest]) do
      [stringify_keys(head) | stringify_keys(rest)]
    end

    def stringify_keys(not_a_map) do
      not_a_map
    end