Fix Hermes cron delivery and rename errors

Author: eimexdev

apps/web/src/components/Sidebar.tsx

@@ -75,6 +75,7 @@ import { useDesktopLocalBootstraps } from "../connection/useDesktopLocalBootstra
 import { isElectron } from "../env";
 import { useOpenPrLink } from "../lib/openPullRequestLink";
 import { isTerminalFocused } from "../lib/terminalFocus";
+import { describeThreadRenameFailure } from "../lib/threadRenameFailure";
 import { isMacPlatform } from "../lib/utils";
 import {
   readThreadShell,
@@ -2059,18 +2060,17 @@ const SidebarProjectItem = memo(function SidebarProjectItem(props: SidebarProjec
         finishRename();
         return;
       }
+      finishRename();
       const result = await renameThreadTitle(threadRef, trimmed);
-      if (result._tag === "Failure" && !isAtomCommandInterrupted(result)) {
-        const error = squashAtomCommandFailure(result);
+      const failureMessage = describeThreadRenameFailure(result);
+      if (failureMessage) {
         toastManager.add(
           stackedThreadToast({
             type: "error",
-            title: "Failed to rename thread",
-            description: error instanceof Error ? error.message : "An error occurred.",
+            ...failureMessage,
           }),
         );
       }
-      finishRename();
     },
     [renameThreadTitle],
   );

apps/web/src/components/SidebarV2.tsx

@@ -56,6 +56,7 @@ import {
 import { useShortcutModifierState } from "../shortcutModifierState";
 import { isTerminalFocused } from "../lib/terminalFocus";
 import { isModelPickerOpen } from "../modelPickerVisibility";
+import { describeThreadRenameFailure } from "../lib/threadRenameFailure";
 import { selectThreadTerminalUiState, useTerminalUiStateStore } from "../terminalUiStateStore";
 import { isMacPlatform } from "~/lib/utils";
 import { useOpenPrLink } from "../lib/openPullRequestLink";
@@ -1343,13 +1344,12 @@ export default function SidebarV2() {
         }
         if (trimmed === originalTitle) return;
         const result = await renameThreadTitle(threadRef, trimmed);
-        if (result._tag === "Failure" && !isAtomCommandInterrupted(result)) {
-          const error = squashAtomCommandFailure(result);
+        const failureMessage = describeThreadRenameFailure(result);
+        if (failureMessage) {
           toastManager.add(
             stackedThreadToast({
               type: "error",
-              title: "Failed to rename thread",
-              description: error instanceof Error ? error.message : "An error occurred.",
+              ...failureMessage,
             }),
           );
         }

apps/web/src/lib/threadRenameFailure.test.ts

@@ -0,0 +1,27 @@
+import { describe, expect, it } from "vite-plus/test";
+import * as Cause from "effect/Cause";
+import { AsyncResult } from "effect/unstable/reactivity";
+
+import { describeThreadRenameFailure } from "./threadRenameFailure";
+
+describe("describeThreadRenameFailure", () => {
+  it("explains an interrupted Hermes rename instead of hiding it", () => {
+    const message = describeThreadRenameFailure(AsyncResult.failure(Cause.interrupt()));
+
+    expect(message).toEqual({
+      title: "Thread rename interrupted",
+      description: "The connection changed before Hermes confirmed the new title. Try again.",
+    });
+  });
+
+  it("preserves an ordinary rename failure message", () => {
+    const message = describeThreadRenameFailure(
+      AsyncResult.failure(Cause.fail(new Error("Hermes rejected the title"))),
+    );
+
+    expect(message).toEqual({
+      title: "Failed to rename thread",
+      description: "Hermes rejected the title",
+    });
+  });
+});

apps/web/src/lib/threadRenameFailure.ts

@@ -0,0 +1,29 @@
+import type { AtomCommandResult } from "@t3tools/client-runtime/state/runtime";
+import {
+  isAtomCommandInterrupted,
+  squashAtomCommandFailure,
+} from "@t3tools/client-runtime/state/runtime";
+
+export interface ThreadRenameFailureMessage {
+  readonly title: string;
+  readonly description: string;
+}
+
+export function describeThreadRenameFailure(
+  result: AtomCommandResult<unknown, unknown>,
+): ThreadRenameFailureMessage | null {
+  if (result._tag !== "Failure") {
+    return null;
+  }
+  if (isAtomCommandInterrupted(result)) {
+    return {
+      title: "Thread rename interrupted",
+      description: "The connection changed before Hermes confirmed the new title. Try again.",
+    };
+  }
+  const error = squashAtomCommandFailure(result);
+  return {
+    title: "Failed to rename thread",
+    description: error instanceof Error ? error.message : "An error occurred.",
+  };
+}

integrations/hermes/t3agent/adapter.py

@@ -2199,23 +2199,41 @@ async def _post_event(
             "Content-Type": "application/json",
             "Idempotency-Key": request_id,
         }
-        active_client = client or self._client
-        if active_client is None:
+        configured_client = client or self._client
+        if configured_client is None or configured_client.closed:
             return False, {}, "T3 Agent bridge is not connected"
-        try:
+
+        async def post_event(
+            active_client: ClientSession,
+        ) -> Tuple[Optional[Dict[str, Any]], Optional[str]]:
             async with active_client.post(target, json=frame, headers=headers) as response:
                 if not 200 <= response.status < 300:
-                    return False, {}, f"T3 Agent bridge returned HTTP {response.status}"
+                    return None, f"T3 Agent bridge returned HTTP {response.status}"
                 try:
-                    body = await response.json()
+                    response_body = await response.json()
                 except Exception:
-                    return False, {}, "T3 Agent bridge returned invalid JSON"
+                    return None, "T3 Agent bridge returned invalid JSON"
+            if not isinstance(response_body, dict):
+                return None, "T3 Agent bridge returned invalid JSON"
+            return response_body, None
+
+        try:
+            client_loop = getattr(configured_client, "_loop", None)
+            if client_loop is asyncio.get_running_loop():
+                body, request_error = await post_event(configured_client)
+            else:
+                # Hermes cron delivery can call the connected adapter from its
+                # scheduler loop. aiohttp sessions are bound to the loop where
+                # they were created, so use a request-local session here.
+                timeout = ClientTimeout(total=self.timeout_seconds)
+                async with ClientSession(timeout=timeout) as active_client:
+                    body, request_error = await post_event(active_client)
         except asyncio.CancelledError:
             raise
         except (ClientError, asyncio.TimeoutError):
             return False, {}, "T3 Agent bridge request failed"
-        if not isinstance(body, dict):
-            return False, {}, "T3 Agent bridge returned invalid JSON"
+        if body is None:
+            return False, {}, request_error or "T3 Agent bridge request failed"
         if body.get("protocolVersion") != PROTOCOL_VERSION:
             return False, body, "T3 Agent bridge returned a mismatched protocol version"
         if body.get("requestId") != request_id:

integrations/hermes/t3agent/tests/test_adapter.py

@@ -3,6 +3,7 @@
 import asyncio
 import json
 import os
+import threading
 from types import SimpleNamespace
 from typing import Any, Dict, Iterator, List
 
@@ -1147,6 +1148,63 @@ async def receive(request: web.Request) -> web.Response:
         await server.close()
 
 
+@pytest.mark.asyncio
+async def test_send_uses_current_loop_when_connected_client_belongs_to_gateway_loop(
+    fake_platform: SimpleNamespace,
+) -> None:
+    received: List[Dict[str, Any]] = []
+
+    async def receive(request: web.Request) -> web.Response:
+        frame = await request.json()
+        received.append(frame)
+        return web.json_response(
+            {
+                "protocolVersion": 1,
+                "requestId": frame["requestId"],
+                "deliveryId": frame["deliveryId"],
+                "status": "accepted",
+            }
+        )
+
+    app = web.Application()
+    app.router.add_post("/api/hermes/hermes-test/events", receive)
+    server = TestServer(app)
+    await server.start_server()
+
+    gateway_loop = asyncio.new_event_loop()
+    gateway_thread = threading.Thread(target=gateway_loop.run_forever)
+    gateway_thread.start()
+
+    async def create_gateway_client() -> ClientSession:
+        return ClientSession()
+
+    gateway_client = asyncio.run_coroutine_threadsafe(
+        create_gateway_client(), gateway_loop
+    ).result()
+    adapter = adapter_module.T3AgentAdapter(
+        make_config(bridge_url=str(server.make_url("/")))
+    )
+    adapter.bridge_url = adapter.bridge_url.rstrip("/")
+    adapter._client = gateway_client
+    try:
+        result = await adapter.send(
+            "t3agent",
+            "scheduled result",
+            metadata={"threadId": "thread-1", "final": True},
+        )
+
+        assert result.success is True
+        assert received[0]["content"] == "scheduled result"
+        assert received[0]["threadId"] == "thread-1"
+    finally:
+        asyncio.run_coroutine_threadsafe(gateway_client.close(), gateway_loop).result()
+        adapter._client = None
+        gateway_loop.call_soon_threadsafe(gateway_loop.stop)
+        gateway_thread.join()
+        gateway_loop.close()
+        await server.close()
+
+
 @pytest.mark.asyncio
 async def test_stream_metadata_marks_preview_then_routes_final_edit(
     fake_platform: SimpleNamespace,