From d5b5006732406d8da0c4fbdb27b4e5730966c8d1 Mon Sep 17 00:00:00 2001
From: edithatogo <15080672+edithatogo@users.noreply.github.com>
Date: Tue, 28 Jul 2026 14:49:40 +0000
Subject: [PATCH] =?UTF-8?q?=E2=9A=A1=20optimize=20performance=20of=20=5Fre?=
 =?UTF-8?q?ferential=5Fintegrity=20loop=20lookups?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

---
 .../tools/src/pic_contracts/validation.py     | 86 +++++++++++--------
 1 file changed, 49 insertions(+), 37 deletions(-)

diff --git a/contracts/tools/src/pic_contracts/validation.py b/contracts/tools/src/pic_contracts/validation.py
index bd697516..1d49a9aa 100644
--- a/contracts/tools/src/pic_contracts/validation.py
+++ b/contracts/tools/src/pic_contracts/validation.py
@@ -508,48 +508,60 @@ def _referential_integrity(paths: list[Path]) -> list[ValidationIssue]:
     parameter_ids: set[str] = set()
     for _, contract, doc in docs:
         if contract == "pic-crosswalk":
-            for row in doc.get("rows", []):
-                crosswalk_types[row.get("id", "")] = row.get("dataType", "")
+            rows = doc.get("rows")
+            if rows:
+                for row in rows:
+                    crosswalk_types[row.get("id", "")] = row.get("dataType", "")
         elif contract == "pic-parameters":
-            for parameter in doc.get("parameters", []):
-                parameter_ids.add(parameter.get("id", ""))
+            parameters = doc.get("parameters")
+            if parameters:
+                for parameter in parameters:
+                    parameter_ids.add(parameter.get("id", ""))
 
     for path, contract, doc in docs:
         if contract == "pic-fixtures":
-            for case_index, case in enumerate(doc.get("cases", [])):
-                for pic_id, value_object in case.get("inputs", {}).items():
-                    if pic_id not in crosswalk_types:
-                        issues.append(
-                            ValidationIssue(
-                                f"{path}:cases/{case_index}/inputs/{pic_id}",
-                                "fixture references unknown crosswalk ID",
-                                "reference",
-                            )
-                        )
-                        continue
-                    expected_type = crosswalk_types[pic_id]
-                    actual_type = _infer_value_data_type(value_object)
-                    if actual_type is not None and expected_type != actual_type:
-                        issues.append(
-                            ValidationIssue(
-                                f"{path}:cases/{case_index}/inputs/{pic_id}",
-                                "type mismatch: "
-                                f"crosswalk={expected_type} fixture={actual_type}",
-                                "type",
-                            )
-                        )
+            cases = doc.get("cases")
+            if cases:
+                for case_index, case in enumerate(cases):
+                    inputs = case.get("inputs")
+                    if inputs:
+                        for pic_id, value_object in inputs.items():
+                            if pic_id not in crosswalk_types:
+                                issues.append(
+                                    ValidationIssue(
+                                        f"{path}:cases/{case_index}/inputs/{pic_id}",
+                                        "fixture references unknown crosswalk ID",
+                                        "reference",
+                                    )
+                                )
+                                continue
+                            expected_type = crosswalk_types[pic_id]
+                            actual_type = _infer_value_data_type(value_object)
+                            if actual_type is not None and expected_type != actual_type:
+                                issues.append(
+                                    ValidationIssue(
+                                        f"{path}:cases/{case_index}/inputs/{pic_id}",
+                                        "type mismatch: "
+                                        f"crosswalk={expected_type} fixture={actual_type}",
+                                        "type",
+                                    )
+                                )
         elif contract == "pic-traces":
-            for step_index, step in enumerate(doc.get("steps", [])):
-                for version_index, parameter in enumerate(step.get("parameterVersions", [])):
-                    parameter_id = parameter.get("id")
-                    if parameter_id not in parameter_ids:
-                        issues.append(
-                            ValidationIssue(
-                                f"{path}:steps/{step_index}/parameterVersions/{version_index}",
-                                "trace references unknown parameter ID",
-                                "reference",
-                            )
-                        )
+            steps = doc.get("steps")
+            if steps:
+                for step_index, step in enumerate(steps):
+                    parameter_versions = step.get("parameterVersions")
+                    if parameter_versions:
+                        for version_index, parameter in enumerate(parameter_versions):
+                            parameter_id = parameter.get("id")
+                            if parameter_id not in parameter_ids:
+                                issues.append(
+                                    ValidationIssue(
+                                        f"{path}:steps/{step_index}/parameterVersions/{version_index}",
+                                        "trace references unknown parameter ID",
+                                        "reference",
+                                    )
+                                )
     return issues