Skip to content

Commit 2dbdb33

Browse files
refactor: consolidate authorization extension admin scopes (#1022)
refactor(identity-api): consolidate authorization extension and drop redundant JWKS URL validation Switch the issuerservice-oauth2 BOM to the shared identityhub-api-authorization extension and remove the duplicate JWKS URL parsing in Oauth2JwtAuthenticationExtension, which is already validated during config checks. Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
1 parent 4d8100b commit 2dbdb33

2 files changed

Lines changed: 2 additions & 8 deletions

File tree

‎dist/bom/issuerservice-oauth2-bom/build.gradle.kts‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,9 +20,9 @@ plugins {
2020
dependencies {
2121
implementation(project(":dist:bom:issuerservice-base-bom"))
2222
implementation(project(":extensions:api:issuer-admin-api:issuer-admin-api-authentication-oauth2"))
23-
implementation(project(":extensions:api:issuer-admin-api:issuer-admin-api-authorization-oauth2"))
23+
implementation(project(":extensions:api:identityhub-api-authorization"))
2424
implementation(project(":extensions:api:identity-api:identity-api-authentication-oauth2"))
25-
implementation(project(":extensions:api:identity-api:identity-api-authorization-oauth2"))
25+
// implementation(project(":extensions:api:identity-api:identity-api-authorization-oauth2"))
2626
// needed for interaction with the embedded STS
2727
implementation(project(":extensions:sts:sts-core"))
2828
implementation(project(":extensions:sts:sts-account-service-local"))

‎extensions/api/identity-api/identity-api-authentication-oauth2/src/main/java/org/eclipse/edc/identityhub/api/Oauth2JwtAuthenticationExtension.java‎

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -81,12 +81,6 @@ public void initialize(ServiceExtensionContext context) {
8181

8282
webService.registerResource(alias, new ServicePrincipalAuthenticationFilter(participantContextService, IdentityApiScopes.ADMIN));
8383

84-
URL url;
85-
try {
86-
url = new URL(oauthConfiguration.jwksUrl());
87-
} catch (MalformedURLException e) {
88-
throw new EdcException(e);
89-
}
9084
var resolver = JwksPublicKeyResolver.create(keyParserRegistry, oauthConfiguration.jwksUrl(), monitor, oauthConfiguration.cacheValidityInMillis());
9185
webService.registerResource(alias, new JwtValidatorFilter(tokenValidationService, resolver, getRules()));
9286
}

0 commit comments

Comments
 (0)