Remove setting of SERIALIZED_MEMBER_SIZE when serializing vector of booleans as array (#332)

* Fix

Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>

* Fix uncrustify

Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>

---------

Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
(cherry picked from commit 4f983f2)

Author: richiware

src/cpp/Cdr.cpp

@@ -263,7 +263,8 @@ Cdr& Cdr::read_encapsulation()
                 }
                 break;
             default:
-                throw BadParamException("Unexpected encoding algorithm received in Cdr::read_encapsulation for DDS CDR");
+                throw BadParamException(
+                          "Unexpected encoding algorithm received in Cdr::read_encapsulation for DDS CDR");
         }
         reset_callbacks();
 
@@ -2209,11 +2210,6 @@ Cdr& Cdr::serialize_bool_array(
         throw NotEnoughMemoryException(NotEnoughMemoryException::NOT_ENOUGH_MEMORY_MESSAGE_DEFAULT);
     }
 
-    if (CdrVersion::XCDRv2 == cdr_version_)
-    {
-        serialized_member_size_ = SERIALIZED_MEMBER_SIZE;
-    }
-
     return *this;
 }
 

test/cdr/array_as_std_vector.cpp

@@ -25,7 +25,7 @@ using XCdrStreamValues =
         std::array<std::vector<uint8_t>,
                 1 + EncodingAlgorithmFlag::PL_CDR2 + Cdr::Endianness::LITTLE_ENDIANNESS>;
 
-class CdrArrayAsSTDVectorTest : public ::testing::TestWithParam< std::tuple<EncodingAlgorithmFlag, Cdr::Endianness>>
+class CdrArrayAsSTDVectorTest : public ::testing::TestWithParam<std::tuple<EncodingAlgorithmFlag, Cdr::Endianness>>
 {
 };
 
@@ -266,6 +266,75 @@ TEST_P(CdrArrayAsSTDVectorTest, array_ulong_as_std_vector)
     serialize_array(expected_streams, encoding, endianness, array_value);
 }
 
+/*!
+ * @test Test an array of boolean type stored in a std::vector.
+ */
+TEST_P(CdrArrayAsSTDVectorTest, array_bool_as_std_vector)
+{
+    const std::vector<bool> array_value {true, false};
+    constexpr uint8_t tval {0x01};
+    constexpr uint8_t fval {0x00};
+
+    //{ Defining expected XCDR streams
+    XCdrStreamValues expected_streams;
+    expected_streams[0 + EncodingAlgorithmFlag::PLAIN_CDR + Cdr::Endianness::BIG_ENDIANNESS] =
+    {
+        0x00, 0x00, 0x00, 0x00, // Encapsulation
+        tval, fval              // Boolean
+    };
+    expected_streams[0 + EncodingAlgorithmFlag::PLAIN_CDR + Cdr::Endianness::LITTLE_ENDIANNESS] =
+    {
+        0x00, 0x01, 0x00, 0x00, // Encapsulation
+        tval, fval              // Boolean
+    };
+    expected_streams[0 + EncodingAlgorithmFlag::PL_CDR + Cdr::Endianness::BIG_ENDIANNESS] =
+    {
+        0x00, 0x02, 0x00, 0x00, // Encapsulation
+        tval, fval              // Boolean
+    };
+    expected_streams[0 + EncodingAlgorithmFlag::PL_CDR + Cdr::Endianness::LITTLE_ENDIANNESS] =
+    {
+        0x00, 0x03, 0x00, 0x00, // Encapsulation
+        tval, fval              // Boolean
+    };
+    expected_streams[0 + EncodingAlgorithmFlag::PLAIN_CDR2 + Cdr::Endianness::BIG_ENDIANNESS] =
+    {
+        0x00, 0x06, 0x00, 0x00, // Encapsulation
+        tval, fval              // Boolean
+    };
+    expected_streams[0 + EncodingAlgorithmFlag::PLAIN_CDR2 + Cdr::Endianness::LITTLE_ENDIANNESS] =
+    {
+        0x00, 0x07, 0x00, 0x00, // Encapsulation
+        tval, fval              // Boolean
+    };
+    expected_streams[0 + EncodingAlgorithmFlag::DELIMIT_CDR2 + Cdr::Endianness::BIG_ENDIANNESS] =
+    {
+        0x00, 0x08, 0x00, 0x00, // Encapsulation
+        tval, fval              // Boolean
+    };
+    expected_streams[0 + EncodingAlgorithmFlag::DELIMIT_CDR2 + Cdr::Endianness::LITTLE_ENDIANNESS] =
+    {
+        0x00, 0x09, 0x00, 0x00, // Encapsulation
+        tval, fval              // Boolean
+    };
+    expected_streams[0 + EncodingAlgorithmFlag::PL_CDR2 + Cdr::Endianness::BIG_ENDIANNESS] =
+    {
+        0x00, 0x0A, 0x00, 0x00, // Encapsulation
+        tval, fval              // Boolean
+    };
+    expected_streams[0 + EncodingAlgorithmFlag::PL_CDR2 + Cdr::Endianness::LITTLE_ENDIANNESS] =
+    {
+        0x00, 0x0B, 0x00, 0x00, // Encapsulation
+        tval, fval              // Boolean
+    };
+    //}
+
+    EncodingAlgorithmFlag encoding = std::get<0>(GetParam());
+    Cdr::Endianness endianness = std::get<1>(GetParam());
+
+    serialize_array(expected_streams, encoding, endianness, array_value);
+}
+
 /*!
  * @test Test an array of struct type stored in a std::vector.
  * @code{.idl}