Skip to content

Button: add a nativeType for submit since current type is being used for primary,secondary etc. #16

Description

@sharvilak11

Can't manually set type="submit" on the button since type prop is being set for something else. This is not ideal since attrs should be treated as attrs. You can do something like v-bind="$attrs" but then type is meant for something else that is reset, submit, button. But this is not worth changing type prop since it would be breaking change.

I would recommend having nativeType as well as support for attrs with v-bind="$attrs" in this component, since it's a basic form level component.

Type of Issue

  • Bug fix
  • New feature

Expected Behavior

Current Behavior

Possible Solution

Add a new prop for now nativeType.

But when major release is done, remove type and rename it as something else so that attrs and props don't clash.

Steps to Reproduce

Context (Environment)

http://reiyoshizawa.com/vue-listeners-attrs/

Detailed Description

Possible Implementation

http://reiyoshizawa.com/vue-listeners-attrs/

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions