Issue Summary
I've noticed that the repetition_penalty parameter appears to be defined in the codebase but doesn't seem to be fully functional in practice. I'm wondering if there are any plans to implement this feature completely.
Background
The repetition_penalty is an important sampling parameter for controlling text generation quality by reducing repetitive outputs. While the parameter is accepted by the framework, it seems like the actual implementation may be missing or incomplete.
Current Behavior
- The
repetition_penalty parameter can be set in the API/configuration
- However, setting different values (e.g., 1.0, 1.5, 2.0) doesn't appear to produce the expected effect on reducing repetitions in generated text
- The parameter definition exists but may not be actively used during the generation process
Expected Behavior
When repetition_penalty is set to a value greater than 1.0, it should:
- Penalize tokens that have already appeared in the sequence
- Reduce repetitive patterns in generated text
- Provide more diverse and natural outputs
Questions
- Is there a roadmap for implementing the full
repetition_penalty functionality?
- Are there any technical challenges preventing its implementation?
- Is there a workaround or alternative approach currently available?
- If implementation is planned, what's the estimated timeline?
Environment
- Version: Jetson AGX Orin
- Platform: Ubuntu 22.04.5 LTS
- Use case: VLM inference, like vila model
Thank you for your time and consideration!
Issue Summary
I've noticed that the
repetition_penaltyparameter appears to be defined in the codebase but doesn't seem to be fully functional in practice. I'm wondering if there are any plans to implement this feature completely.Background
The
repetition_penaltyis an important sampling parameter for controlling text generation quality by reducing repetitive outputs. While the parameter is accepted by the framework, it seems like the actual implementation may be missing or incomplete.Current Behavior
repetition_penaltyparameter can be set in the API/configurationExpected Behavior
When
repetition_penaltyis set to a value greater than 1.0, it should:Questions
repetition_penaltyfunctionality?Environment
Thank you for your time and consideration!