fix: race condition fixed for BatchProcessorTest

Author: dsmithson

README.md

@@ -3,7 +3,6 @@
 A .NET Standard 2.0 library providing helpful utility classes for threading, networking, collections, and other common patterns frequently used across projects.
 
 [![CI](https://github.com/dsmithson/KnightwareCore/actions/workflows/ci.yml/badge.svg)](https://github.com/dsmithson/KnightwareCore/actions/workflows/ci.yml)
-[![Quality Gate Status](https://sonarcloud.io/api/project_badges/measure?project=dsmithson_KnightwareCore&metric=alert_status)](https://sonarcloud.io/dashboard?id=dsmithson_KnightwareCore)
 [![codecov](https://codecov.io/gh/dsmithson/KnightwareCore/branch/main/graph/badge.svg)](https://codecov.io/gh/dsmithson/KnightwareCore)
 [![NuGet](https://img.shields.io/nuget/v/KnightwareCore.svg)](https://www.nuget.org/packages/KnightwareCore/)
 

src/KnightwareCoreTests/Threading/Tasks/BatchProcessorTests.cs

@@ -210,6 +210,7 @@ public async Task MinimumElapsedMultipleTest()
 
             var batchesSizesProcessed = new List<int>();
             int itemsProcessedInCurrentBatch = 0;
+            var batchCompleteSignal = new TaskCompletionSource<bool>();
 
             //Setup a handler that will increment our batch process count per item and add the batch count and a timestamp when a batch completes
             await TestSimpleSetup(
@@ -222,25 +223,30 @@ await TestSimpleSetup(
                 {
                     batchesSizesProcessed.Add(itemsProcessedInCurrentBatch);
                     itemsProcessedInCurrentBatch = 0;
+                    batchCompleteSignal.TrySetResult(true);
                 },
                 minimumTimeIntervalMs: minMs,
                 maximumTimeIntervalMs: 10000,
                 maximumCount: int.MaxValue);
 
             //Run our test duration, adding items as needed
-            List<Task> tasks = new(); 
             for(int i=0; i<expectedBatches; i++)
             {
-                //We'll add a couple items, then wait for our min refresh time to elapse
+                //Reset signal for this batch
+                batchCompleteSignal = new TaskCompletionSource<bool>();
+
+                //Add item(s) for this batch
+                List<Task> batchTasks = new();
                 for (int j = 0; j < expectedItemsPerBatch; j++)
                 {
-                    tasks.Add(processor.EnqueueAsync(0));
+                    batchTasks.Add(processor.EnqueueAsync(0));
                 }
-                await Task.Delay(minMs * 2);
-            }
 
-            //Wait for last batch to finish...
-            await Task.WhenAll(tasks);
+                //Wait for the batch to fully complete (including onBatchProcessed callback)
+                //Task.WhenAll only waits for SetResponse, but we need to wait for the callback too
+                await Task.WhenAll(batchTasks);
+                await batchCompleteSignal.Task;
+            }
 
             //Verify we processed the correct number of batches
             Assert.HasCount(expectedBatches, batchesSizesProcessed, "Incorrect number of batches processed");