chore: unit test updates

Author: dsmithson

src/KnightwareCoreTests/Collections/ListExtensionsTests.cs

@@ -83,7 +83,7 @@ public void CopyToRemovesMissingItemsTest()
                 (s, d) => d.Name = s.Name,
                 removed => removedItem = removed);
 
-            Assert.AreEqual(1, destination.Count);
+            Assert.HasCount(1, destination);
             Assert.IsNotNull(removedItem);
             Assert.AreEqual(2, removedItem.Id);
         }
@@ -105,7 +105,6 @@ public void CopyToWithNullSourceDoesNotThrowTest()
         public void CopyToWithNullDestinationDoesNotThrowTest()
         {
             var source = new List<SourceItem> { new SourceItem { Id = 1 } };
-
             source.CopyTo<SourceItem, DestItem, int>(
                 null,
                 s => s.Id,

src/KnightwareCoreTests/Drawing/BitmapHelperTest.cs

@@ -1,10 +1,6 @@
 using Microsoft.VisualStudio.TestTools.UnitTesting;
 using System;
-using System.Collections.Generic;
-using System.Drawing;
 using System.IO;
-using System.Text;
-
 
 namespace Knightware.Drawing
 {
@@ -21,19 +17,43 @@ public void DrawSolidBitmapTest()
             const int width = 808;
             const int height = 402;
 
-            using (var stream = BitmapHelper.GenerateSolidColorBitmap(Primitives.Color.FromArgb(a, r, g, b), width, height))
-            {
-                stream.Seek(0, SeekOrigin.Begin);
+            using var stream = BitmapHelper.GenerateSolidColorBitmap(Primitives.Color.FromArgb(a, r, g, b), width, height);
+            stream.Seek(0, SeekOrigin.Begin);
+
+            // Parse BMP header directly (works cross-platform without System.Drawing)
+            using var reader = new BinaryReader(stream);
+
+            // BMP Header (14 bytes)
+            var signature = new string(reader.ReadChars(2));
+            Assert.AreEqual("BM", signature, "Invalid BMP signature");
+
+            var fileSize = reader.ReadInt32();
+            reader.ReadInt32(); // Reserved
+            var dataOffset = reader.ReadInt32();
+
+            // DIB Header
+            var dibHeaderSize = reader.ReadInt32();
+            var bmpWidth = reader.ReadInt32();
+            var bmpHeight = reader.ReadInt32();
+
+            Assert.AreEqual(width, bmpWidth, "Width was incorrect");
+            Assert.AreEqual(height, bmpHeight, "Height was incorrect");
+
+            // Skip to pixel data and verify color
+            reader.ReadInt16(); // planes
+            var bitsPerPixel = reader.ReadInt16();
+            Assert.AreEqual(24, bitsPerPixel, "Expected 24-bit BMP");
+
+            stream.Seek(dataOffset, SeekOrigin.Begin);
 
-                //Use System.Drawing bitmap to confirm
-                using (var bitmap = Bitmap.FromStream(stream))
-                {
-                    Assert.AreEqual(width, bitmap.Width, "Width was incorrect");
-                    Assert.AreEqual(height, bitmap.Height, "Height was incorrect");
+            // Read first pixel (BGR order in BMP)
+            byte pixelB = reader.ReadByte();
+            byte pixelG = reader.ReadByte();
+            byte pixelR = reader.ReadByte();
 
-                    //TODO:  Test all the pixels for the correct color
-                }
-            }
+            Assert.AreEqual(b, pixelB, "Blue channel was incorrect");
+            Assert.AreEqual(g, pixelG, "Green channel was incorrect");
+            Assert.AreEqual(r, pixelR, "Red channel was incorrect");
         }
     }
-}
+}

src/KnightwareCoreTests/PropertyChangedBaseTests.cs

@@ -59,13 +59,6 @@ public void PropertyChangedWithExplicitNameTest()
             Assert.AreEqual("Value", changedPropertyName);
         }
 
-        [TestMethod]
-        public void PropertyChangedNotRaisedWithoutSubscriberTest()
-        {
-            var obj = new TestPropertyChangedClass();
-            obj.Name = "Test";
-        }
-
         [TestMethod]
         public void MultiplePropertyChangedEventsTest()
         {

src/KnightwareCoreTests/Threading/Tasks/BatchProcessorTests.cs

@@ -228,18 +228,19 @@ await TestSimpleSetup(
                 maximumCount: int.MaxValue);
 
             //Run our test duration, adding items as needed
+            List<Task> tasks = new(); 
             for(int i=0; i<expectedBatches; i++)
             {
                 //We'll add a couple items, then wait for our min refresh time to elapse
                 for (int j = 0; j < expectedItemsPerBatch; j++)
                 {
-                    Task t1 = processor.EnqueueAsync(0);
+                    tasks.Add(processor.EnqueueAsync(0));
                 }
                 await Task.Delay(minMs * 2);
             }
-            
+
             //Wait for last batch to finish...
-            await Task.Delay(1000);
+            await Task.WhenAll(tasks);
 
             //Verify we processed the correct number of batches
             Assert.HasCount(expectedBatches, batchesSizesProcessed, "Incorrect number of batches processed");