What would you like to improve?
Hi,
I just upgraded to Dreeve and was trying to import a fit file exported by strava (the "export original" option). All my Apple Watch activities are pushed to strava via Healthfit, which gives them just a as title.
One new fit file always silently failed to import since it was seen as a duplicate. After looking at the code it seems DuplicateActivityScanner::isDuplicate() first checks existsStravaActivityForFilename() which matches purely on externalReferenceId = <incoming filename> against activities that are already synced, without a check on startdate, sport-type, ...
So if an old activity shares a filename with a new one, it gets flagged as a duplicate, even if they are recordings of a different activity-type.
What would you like to improve?
Hi,
I just upgraded to Dreeve and was trying to import a fit file exported by strava (the "export original" option). All my Apple Watch activities are pushed to strava via Healthfit, which gives them just a as title.
One new fit file always silently failed to import since it was seen as a duplicate. After looking at the code it seems
DuplicateActivityScanner::isDuplicate()first checksexistsStravaActivityForFilename()which matches purely onexternalReferenceId = <incoming filename>against activities that are already synced, without a check on startdate, sport-type, ...So if an old activity shares a filename with a new one, it gets flagged as a duplicate, even if they are recordings of a different activity-type.