From 39feb0064bdb938e2852525ac6f399f931ded536 Mon Sep 17 00:00:00 2001 From: Douglas Hellinger Date: Mon, 23 Feb 2026 21:59:46 +0800 Subject: [PATCH] fix(release): guard publish steps with success() check Explicit if conditions replace GitHub Actions' implicit success() guard. Without it, a publish step with only inputs.registry != 'ovsx' would run even if tests or packaging failed. Co-Authored-By: Claude --- .github/workflows/release.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index 0507b67..661bd35 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -53,13 +53,13 @@ jobs: run: npm run package - name: Publish to VS Code Marketplace - if: inputs.registry != 'ovsx' + if: success() && inputs.registry != 'ovsx' run: npm run release:marketplace env: VSCE_PAT: ${{ secrets.VSCE_PAT }} - name: Publish to Open VSX Registry - if: inputs.registry != 'marketplace' + if: success() && inputs.registry != 'marketplace' run: npm run release:ovsx env: OPEN_VSX_TOKEN: ${{ secrets.OPEN_VSX_TOKEN }}