[tests] Remove the 'UseSystem' option.#25649
Conversation
It doesn't do anything different, so there's no need for it.
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
There was a problem hiding this comment.
Pull request overview
This PR removes the unused “UseSystem” test option and associated TESTS_USE_SYSTEM plumbing across CI scripts, Makefiles, xharness, and test configuration parsing, simplifying the test execution path to always use test.config and the locally produced layout.
Changes:
- Removed
TESTS_USE_SYSTEMvariable setup from Azure DevOps templates and Windows generator test script. - Removed
--use-systemoption from xharness and eliminatedtest-system.configgeneration/usage. - Simplified test path resolution/config parsing and project references to no longer branch on “system vs local” behavior.
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| tools/devops/automation/templates/tests/run-tests.yml | Stops exporting TESTS_USE_SYSTEM in CI test jobs. |
| tools/devops/automation/scripts/run-generator-tests-on-windows.ps1 | Removes unused TESTS_USE_SYSTEM env var for Windows generator tests. |
| tests/xtro-sharpie/Makefile | Removes conditional assembly path selection; always uses $(DOTNET_DESTDIR) layout. |
| tests/xharness/Program.cs | Removes the --use-system command-line option. |
| tests/xharness/Harness.cs | Drops UseSystemXamarinIOSMac handling and always loads test.config. |
| tests/mmptest/mmptest.csproj | Removes conditional HintPath; always points to local _mac-build mmp. |
| tests/Makefile | Removes test-system.config target/dependency and stops passing --use-system to xharness. |
| tests/common/Configuration.cs | Removes UseSystem logic and always parses test.config / uses unversioned dotnet root layout. |
| tests/.gitignore | Stops ignoring test-system.config (no longer generated). |
| } | ||
| } | ||
|
|
||
| static bool? is_vsts; // if the system-installed XI/XM should be used instead of the local one. |
✅ [PR Build #c7bfab7] Build passed (Detect API changes) ✅Pipeline on Agent |
This comment has been minimized.
This comment has been minimized.
✅ [PR Build #c7bfab7] Build passed (Build packages) ✅Pipeline on Agent |
✅ API diff for current PR / commitNET (empty diffs)✅ API diff vs stableNET (empty diffs)ℹ️ Generator diffGenerator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes) Pipeline on Agent |
✅ [PR Build #c7bfab7] Build passed (Build macOS tests) ✅Pipeline on Agent |
🔥 [CI Build #c7bfab7] Test results 🔥Test results❌ Tests failed on VSTS: test results 4 tests crashed, 20 tests failed, 163 tests passed. Failures❌ cecil tests🔥 Failed catastrophically on VSTS: test results - cecil (no summary found). Html Report (VSDrops) Download ❌ dotnettests tests (MacCatalyst)🔥 Failed catastrophically on VSTS: test results - dotnettests_maccatalyst (no summary found). Html Report (VSDrops) Download ❌ generator tests🔥 Failed catastrophically on VSTS: test results - generator (no summary found). Html Report (VSDrops) Download ❌ introspection tests4 tests failed, 2 tests passed.Failed tests
Html Report (VSDrops) Download ❌ linker tests (tvOS)11 tests failed, 0 tests passed.Failed tests
Html Report (VSDrops) Download ❌ monotouch tests (macOS)2 tests failed, 21 tests passed.Failed tests
Html Report (VSDrops) Download ❌ sharpie tests1 tests failed, 0 tests passed.Failed tests
Html Report (VSDrops) Download ❌ windows tests🔥 Failed catastrophically on VSTS: test results - windows (no summary found). Html Report (VSDrops) Download ❌ xtro tests1 tests failed, 0 tests passed.Failed tests
Html Report (VSDrops) Download ❌ Tests on macOS Tahoe (26) tests1 tests failed, 4 tests passed.Failed tests
Html Report (VSDrops) Download Successes✅ dotnettests (iOS): All 1 tests passed. Html Report (VSDrops) Download macOS tests✅ Tests on macOS Monterey (12): All 5 tests passed. Html Report (VSDrops) Download Linux Build VerificationPipeline on Agent |
It doesn't do anything different, so there's no need for it.