Update MSBuild package references#25573
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
The package-reference bumps in this branch (Microsoft.Build 17.13.26 -> 17.14.28, System.Text.Json 8.0.5 -> 9.0.16, System.Reflection.MetadataLoadContext 8.0.0 -> 9.0.16) brought System.Formats.Nrbf.dll into each SDK NuGet's tools/msbuild/net10.0/ folder. The signing step fails because the file isn't listed in SignList.xml. It's a Microsoft-signed runtime assembly, so add it to the <Skip> group alongside its sibling System.* tools entries. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
This PR updates MSBuild-related package versions and signing metadata used by the Apple workload build infrastructure.
Changes:
- Bumps Microsoft.Build package versions from 17.13.26 to 17.14.28.
- Updates task project dependencies for
System.Reflection.MetadataLoadContextandSystem.Text.Json. - Removes obsolete explicit
System.Security.Cryptography.Xmlpins and addsSystem.Formats.Nrbf.dllto the signing skip list.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
Directory.Build.props |
Updates shared MSBuild package version and removes the unused cryptography XML version property. |
msbuild/Xamarin.MacDev.Tasks/Xamarin.MacDev.Tasks.csproj |
Updates task dependency versions and removes the explicit cryptography XML package reference. |
msbuild/Messaging/Xamarin.Messaging.Build/Xamarin.Messaging.Build.csproj |
Removes the explicit cryptography XML package reference. |
tests/msbuild/Xamarin.MacDev.Tasks.Tests/Xamarin.MacDev.Tasks.Tests.csproj |
Removes the explicit cryptography XML package reference from tests. |
dotnet/Workloads/SignList.xml |
Marks System.Formats.Nrbf.dll as already signed for workload signing. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
/azp run xamarin-macios-pr,xamarin-macios-pr-apidiff |
|
Azure Pipelines successfully started running 2 pipeline(s). |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
/azp run xamarin-macios-sim-pr-tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
✅ [PR Build #7e0e777] Build passed (Build packages) ✅Pipeline on Agent |
✅ [CI Build #7e0e777] Build passed (Detect API changes) ✅Pipeline on Agent |
This comment has been minimized.
This comment has been minimized.
✅ API diff for current PR / commitNET (empty diffs)✅ API diff vs stableNET (empty diffs)ℹ️ Generator diffGenerator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes) Pipeline on Agent |
This comment has been minimized.
This comment has been minimized.
✅ [CI Build #7e0e777] Build passed (Build macOS tests) ✅Pipeline on Agent |
🔥 [CI Build #7e0e777] Test results 🔥Test results❌ Tests failed on VSTS: test results 0 tests crashed, 5 tests failed, 188 tests passed. Failures❌ monotouch tests (iOS)1 tests failed, 19 tests passed.Failed tests
Html Report (VSDrops) Download ❌ monotouch tests (macOS)1 tests failed, 22 tests passed.Failed tests
Html Report (VSDrops) Download ❌ msbuild tests1 tests failed, 1 tests passed.Failed tests
Html Report (VSDrops) Download ❌ windows tests1 tests failed, 2 tests passed.Failed tests
Html Report (VSDrops) Download ❌ Tests on macOS Tahoe (26) tests1 tests failed, 4 tests passed.Failed tests
Html Report (VSDrops) Download Successes✅ cecil: All 1 tests passed. Html Report (VSDrops) Download macOS tests✅ Tests on macOS Monterey (12): All 5 tests passed. Html Report (VSDrops) Download Linux Build VerificationPipeline on Agent |
✅ [CI Build #7e0e777] Prepare .NET Release succeeded ✅📦 Published NuGet packages (32 packages)iOS
MacCatalyst
macOS
tvOS
Other
Pipeline on Agent |
No description provided.