-
Notifications
You must be signed in to change notification settings - Fork 0
Reconcile the env-var contract (kill dead AZURE_AI_*, fix double-path) #512
Copy link
Copy link
Open
Labels
configConfiguration / env varsConfiguration / env varsdocsDocumentation updatesDocumentation updatesllmLLM narration integrationLLM narration integrationsquad:khelbenAssigned to Khelben (CI/CD Dev)Assigned to Khelben (CI/CD Dev)squad:voloAssigned to Volo (Narrative Dev)Assigned to Volo (Narrative Dev)tech-debtCleanup of dead or misleading code/configCleanup of dead or misleading code/config
Milestone
Description
Activity
Metadata
Metadata
Assignees
Labels
configConfiguration / env varsConfiguration / env varsdocsDocumentation updatesDocumentation updatesllmLLM narration integrationLLM narration integrationsquad:khelbenAssigned to Khelben (CI/CD Dev)Assigned to Khelben (CI/CD Dev)squad:voloAssigned to Volo (Narrative Dev)Assigned to Volo (Narrative Dev)tech-debtCleanup of dead or misleading code/configCleanup of dead or misleading code/config
Summary
.envadvertisesAZURE_AI_ENDPOINT/KEY/DEPLOYMENT/API_VERSIONthat no code reads, and.env:65showsOPENAI_LLM_ENDPOINT=…/v1/chat/completions, which double-appends the path because the transport adds/v1/chat/completionsitself (llm-client.ts:206). This is a latent misconfiguration trap and misleading documentation. Make the env contract match reality.Scope / Tasks
AZURE_AI_*block from.env:59-62(or, if Issue 3 chose to implement them, wire them inconfig.tsand document precedence — pick one, do not leave them dead)..env:65to the base-URL form (https://api.openai.com) matching.env.example:62so the transport's appended path is correct..env.exampleand any deploy docs for the same trap; add an inline comment that the endpoint must be the base URL.AZURE_AI_*in code/docs after change.Acceptance Criteria
grep -rn AZURE_AI packages/ .envreturns nothing dead (either removed or genuinely consumed)..envand.env.exampleagree on the base-URL form; no/v1/chat/completionssuffix in the endpoint value.Dependencies
none (can land early); coordinate with #511 if AZURE_AI is implemented.
Size
S
Derived from the LLM narration gap analysis (Volo) and decomposition (Elminster).