From 114e1f5f6469efcc29dd3eaba8e95f0a95aac2b4 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?M=C3=A9di-R=C3=A9mi=20Hashim?= Date: Tue, 6 Jul 2021 16:39:40 +0100 Subject: [PATCH 1/2] fix: handle UNAPPROVED_ABOVE status --- src/shared/status-tag/status-tag.js | 1 + src/shared/status-tag/use-approval-state.js | 1 + 2 files changed, 2 insertions(+) diff --git a/src/shared/status-tag/status-tag.js b/src/shared/status-tag/status-tag.js index 63d63f7b..3a2e51de 100644 --- a/src/shared/status-tag/status-tag.js +++ b/src/shared/status-tag/status-tag.js @@ -22,6 +22,7 @@ StatusTag.propTypes = { 'UNAPPROVED_READY', 'UNAPPROVED_WAITING', 'UNAPPROVED_ELSEWHERE', + 'UNAPPROVED_ABOVE', 'UNAPPROVABLE', ]), } diff --git a/src/shared/status-tag/use-approval-state.js b/src/shared/status-tag/use-approval-state.js index a13ea816..3592575c 100644 --- a/src/shared/status-tag/use-approval-state.js +++ b/src/shared/status-tag/use-approval-state.js @@ -37,6 +37,7 @@ const useApprovalState = approvalState => { case 'UNAPPROVED_WAITING': case 'UNAPPROVED_ELSEWHERE': + case 'UNAPPROVED_ABOVE': return { icon: Waiting, displayName: i18n.t('Waiting'), From ac2f2c712ceb951332ccd323580770937c38446f Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?M=C3=A9di-R=C3=A9mi=20Hashim?= Date: Wed, 7 Jul 2021 08:48:35 +0100 Subject: [PATCH 2/2] fix: throw on unknown approval state --- src/shared/status-tag/use-approval-state.js | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/shared/status-tag/use-approval-state.js b/src/shared/status-tag/use-approval-state.js index 3592575c..c11db800 100644 --- a/src/shared/status-tag/use-approval-state.js +++ b/src/shared/status-tag/use-approval-state.js @@ -50,6 +50,9 @@ const useApprovalState = approvalState => { displayName: i18n.t('Cannot approve'), type: 'negative', } + + default: + throw new Error(`Unknown approval state: '${approvalState}'`) } }