Skip to content

Commit 9ee7ef6

Browse files
committed
fix(lint): stop skipping the TypeScript files in shared/ and scripts/
eslint's directory mode silently ignores files no config block matches, so npm run lint never saw shared/*.ts or scripts/bun-dom-preload.ts while claiming to lint both directories. The shared/scripts block now parses TS via typescript-eslint, with no-require-imports off for tailwind.config.js as the src block already does. First real catch: the STATES set in gjc-job-projection-protocol.ts was never read; removed.
1 parent 4e0c7f8 commit 9ee7ef6

2 files changed

Lines changed: 6 additions & 4 deletions

File tree

eslint.config.js

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -257,12 +257,12 @@ export default tseslint.config(
257257
},
258258
{
259259
files: [
260-
"shared/**/*.{js,cjs,mjs}",
261-
"scripts/**/*.{js,cjs,mjs}",
260+
"shared/**/*.{js,cjs,mjs,ts}",
261+
"scripts/**/*.{js,cjs,mjs,ts}",
262262
"vite.config.js",
263263
"tailwind.config.js",
264264
],
265-
extends: [js.configs.recommended],
265+
extends: [js.configs.recommended, ...tseslint.configs.recommended],
266266
plugins: {
267267
"import-x": importX,
268268
"unused-imports": unusedImports,
@@ -278,6 +278,9 @@ export default tseslint.config(
278278
rules: {
279279
"no-unused-vars": "off",
280280
"no-control-regex": "off",
281+
"@typescript-eslint/no-unused-vars": "off",
282+
"@typescript-eslint/no-explicit-any": "off",
283+
"@typescript-eslint/no-require-imports": "off",
281284
"unused-imports/no-unused-imports": "error",
282285
"unused-imports/no-unused-vars": [
283286
"error",

shared/gjc-job-projection-protocol.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,6 @@ export type JobTerminalPayload = {
4545

4646
const IDENTIFIER = /^[A-Za-z0-9_.:-]{1,128}$/u;
4747
const TERMINAL_STATES = new Set<JobTerminalOutcome>(['succeeded', 'failed', 'aborted', 'interrupted']);
48-
const STATES = new Set<JobState>(['reserved', 'queued', 'running', 'aborting', 'ready', ...TERMINAL_STATES]);
4948
const ERROR_CODES = new Set<JobProjectionErrorCode>(['invalid_request', 'not_found', 'cursor_ahead', 'cursor_mismatch', 'authority_unavailable', 'storage_failure', 'buffer_overflow', 'protocol_violation']);
5049
const object = (value: unknown): value is Record<string, unknown> => value !== null && typeof value === 'object' && !Array.isArray(value);
5150

0 commit comments

Comments
 (0)