OSPF Check crashes when connection OSPF neighbor is not established/initializing

[simon-mueller]

CheckMK Version: 2.4.0p24
Mikrotik MKP Version: 3.3.0
Mikrotik Version: RouterOS RB750Gr3 (v7.20.1)

Affected section: mikrotik_ospf

Currently, I'm having an OSPF neighbor that is not connected. The state is "Init" and should be classified as a warning. It's not an OK state.

Crash report:

Exception | TypeError ('>' not supported between instances of 'State' and 'State')
-- | --
Traceback | File "/omd/sites/<site>/lib/python3/cmk/base/checkers.py", line 912, in get_aggregated_result     check_result = check_function(**item_kw, **params_kw, **section_kws)   File "/omd/sites/wiesopprum/lib/python3/cmk/base/checkers.py", line 685, in __check_function     return _aggregate_results(consume_check_results(check_function(*args, **kw)))   File "/omd/sites/<site>/lib/python3/cmk/base/checkers.py", line 757, in consume_check_results     for subr in subresults:   File "/omd/sites/<site>/lib/python3/cmk/base/api/agent_based/register/check_plugins.py", line 96, in filtered_generator     for element in generator(*args, **kwargs):   File "/omd/sites/<site>/local/lib/python3/cmk_addons/plugins/mikrotik/agent_based/mikrotik_ospf.py", line 91, in check_mikrotik_ospf     if State.WARN > worst_state: '>' not supported between instances of 'State' and 'State'
Local Variables | {'address': 'fe80...%vlanXXX',  'item': 'x.x.x.x',  'neighbor_data': {'fe80...%vlanXXX': 'Init'},  'ok_states': {'TwoWay', 'Full', '2-Way'},  'params': Parameters({'ok_states': ['Full', 'TwoWay', '2-Way']}),  'section': {x.x.x.x': {'fe80...%vlanXXX': 'Init'}},  'state': 'Init',  'state_details': ['fe80...%vlanXXX: Init (!)'],  'worst_state': <State.OK: 0>}
Crash Type | check
Time | 2026-03-16 17:41:09
Operating System | Debian GNU/Linux 13 (trixie)
Checkmk Version | 2.4.0p23
Edition | cre
Core | nagios
Python Version | 3.12.11 (main, Mar 4 2026, 13:38:56) [GCC 14.2.0]
Python Module Paths | /omd/sites/wiesopprum/local/lib/python3/omd/sites/<site>/lib/python3/cloud/omd/sites/<site>/lib/python312.zip/omd/sites/wiesopprum/lib/python3.12/omd/sites/<site>/lib/python3.12/lib-dynload/omd/sites/<site>/lib/python3.12/site-packages/omd/sites/<site>/lib/python3

[simon-mueller]

I tried to create a PR, but you seem to have disabled it.

Patch:

diff --git a/agent_based/mikrotik_ospf.py b/agent_based/mikrotik_ospf.py
index eb9e18a..30e1c52 100644
--- a/agent_based/mikrotik_ospf.py
+++ b/agent_based/mikrotik_ospf.py
@@ -72,8 +72,10 @@ def check_mikrotik_ospf(
             yield Result(state=State.OK, summary=f"State: {state}")
         elif state == 'Down':
             yield Result(state=State.CRIT, summary=f"State: {state} (!!)")
-        else:
+        elif state == 'Init':
             yield Result(state=State.WARN, summary=f"State: {state} (!)")
+        else:
+            yield Result(state=State.UNKNOWN, summary=f"State: {state} (?)")
     else:
         # RouterOS v6 format with multiple addresses
         worst_state = State.OK
@@ -84,12 +86,13 @@ def check_mikrotik_ospf(
                 state_details.append(f"{address}: {state}")
             elif state == 'Down':
                 state_details.append(f"{address}: {state} (!!)")
-                if State.CRIT > worst_state:
-                    worst_state = State.CRIT
-            else:
+                worst_state = State.CRIT
+            elif state == 'Init':
                 state_details.append(f"{address}: {state} (!)")
-                if State.WARN > worst_state:
-                    worst_state = State.WARN
+                worst_state = State.WARN
+            else:
+                state_details.append(f"{address}: {state} (?)")
+                worst_state = State.UNKNOWN
         
         yield Result(
             state=worst_state,

PS: I don't really understand why my v7 hits the "v6 else branch" in the first place.

[simon-mueller]

I took a look at possible other states the OSPF might be in. Maybe we should add something like:

warn_states = ['Init', 'ExStart', 'Exchange', 'Loading']