From 895575295ddcae3de4b39ca9aa23dab0a0c937c3 Mon Sep 17 00:00:00 2001
From: raven <7156279+RavenX8@users.noreply.github.com>
Date: Wed, 27 Nov 2024 23:17:21 -0500
Subject: [PATCH 1/3] - fix: xml file tags not closed

---
 src/rosecommon/packets/srv_toggle_move_reply.xml | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/rosecommon/packets/srv_toggle_move_reply.xml b/src/rosecommon/packets/srv_toggle_move_reply.xml
index e3ab6be..2fe0321 100644
--- a/src/rosecommon/packets/srv_toggle_move_reply.xml
+++ b/src/rosecommon/packets/srv_toggle_move_reply.xml
@@ -1,7 +1,7 @@
 <packet ePacketType = "PAKWC_TOGGLE_MOVE">
-    <element name = "objectId" type = "uint16_t" default = "0">
+    <element name = "objectId" type = "uint16_t" default = "0" />
     <element name = "type" type = "ToggleMove" />
-    <element name = "runSpeed" type = "uint16_t" default = "0">
+    <element name = "runSpeed" type = "uint16_t" default = "0" />
 
     <simpleType name = "ToggleMove">
         <restriction base = "uint8_t">

From ee2b1f47872e25a1a28b5888035f979c4c70787b Mon Sep 17 00:00:00 2001
From: raven <7156279+RavenX8@users.noreply.github.com>
Date: Wed, 27 Nov 2024 23:18:47 -0500
Subject: [PATCH 2/3] - update: packet generator command line args to match
 latest version

---
 cmake/modules/PacketGenerator.cmake | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/cmake/modules/PacketGenerator.cmake b/cmake/modules/PacketGenerator.cmake
index 3d372e7..7d7167f 100644
--- a/cmake/modules/PacketGenerator.cmake
+++ b/cmake/modules/PacketGenerator.cmake
@@ -78,7 +78,7 @@ function(GENERATE_PACKETS SRCS HDRS)
       OUTPUT "${H_FILE}" "${CXX_FILE}"
       COMMAND ${CMAKE_COMMAND} -E make_directory ${SRC_OUTPATH}
       COMMAND ${CMAKE_COMMAND} -E make_directory ${HDR_OUTPATH}
-      COMMAND utils::packet_generator "${MATCH_PATH}" -h "${HDR_OUTPATH}" -c "${SRC_OUTPATH}"
+      COMMAND utils::packet_generator "${MATCH_PATH}" cpp --output_header_folder "${HDR_OUTPATH}" --output_source_folder "${SRC_OUTPATH}"
       DEPENDS ${ABS_FILE} utils::packet_generator
       COMMENT "Running C++ packetGenerator compiler on ${MATCH_PATH} with root ${IDLROOT}, generating: ${CXX_FILE}, ${H_FILE}"
       VERBATIM)

From d60d88930588d9c1b6942530fc464eb79bc8b9bd Mon Sep 17 00:00:00 2001
From: RavenX8 <7156279+RavenX8@users.noreply.github.com>
Date: Sat, 7 Jun 2025 01:15:10 -0400
Subject: [PATCH 3/3] - fix: issue where strings wouldn't clear out their data
 before being read

---
 src/rosecommon/include/crosewriter.h | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/src/rosecommon/include/crosewriter.h b/src/rosecommon/include/crosewriter.h
index 977cbac..f9400a3 100644
--- a/src/rosecommon/include/crosewriter.h
+++ b/src/rosecommon/include/crosewriter.h
@@ -99,6 +99,7 @@ class CRoseReader {
         bool get_uint64_t(uint64_t& data) { return read(data); }
         bool get_int64_t(int64_t& data) { return read(data); }
         bool get_string(std::string& data) {
+            data.clear();
             char c = '\0';
             if (!read(c)) return false;
             while (c != '\0') {
@@ -108,6 +109,7 @@ class CRoseReader {
             return true;
         }
         bool get_string(std::string& data, size_t size) {
+            data.clear();
             for (size_t i = 0; i < size; ++i) {
                 char c;
                 if (!read(c)) return false;