Irondrop: migrate from file based loogging to dir

* Generate and add more tests, Fix some failures and remove monkey code.

Author: dev-harsh1998

README.md

@@ -242,7 +242,7 @@ IronDrop has extensive documentation covering its architecture, API, and feature
 
 ## Testing
 
-IronDrop is rigorously tested with **106 comprehensive tests across 15 test files** covering all aspects of functionality.
+IronDrop is rigorously tested with **179 comprehensive tests across 16 test files** covering all aspects of functionality.
 
 ### Test Categories
 - **Integration Tests** (8 tests): End-to-end functionality and HTTP handling
@@ -278,7 +278,7 @@ IronDrop is licensed under the [MIT License](./LICENSE).
 <div align="center">
   <p>
     <strong>Made with ❤️ and 🦀 in Rust</strong><br>
-    <em>Zero dependencies • Production ready • Battle tested with 106 comprehensive tests</em>
+    <em>Zero dependencies • Production ready • Battle tested with 179 comprehensive tests</em>
   </p>
   <p>
     <a href="https://github.com/dev-harsh1998/IronDrop">⭐ Star us on GitHub</a>

config/irondrop.ini

@@ -193,6 +193,19 @@ verbose = true
 # 💡 Good for production monitoring without overwhelming detail
 detailed = true
 
+# 📁 Log Directory - Where to save log files (optional)
+# • If not specified, logs go to console only
+# • Directory must exist and be writable
+# • Log files are automatically timestamped: irondrop_<timestamp>.log
+# 
+# 💡 Examples:
+# • log_dir = /var/log/irondrop
+# • log_dir = ./logs
+# • log_dir = /home/user/irondrop-logs
+# 
+# ⚠️  Note: Make sure the directory exists before starting IronDrop!
+# log_dir = /var/log/irondrop
+
 # ===============================================================================
 # 📚 CONFIGURATION EXAMPLES
 # ===============================================================================

doc/ARCHITECTURE.md

@@ -179,7 +179,7 @@ tests/
 ├── test_1gb_upload.sh       # Large file upload testing
 └── test_executable_portability.sh # Portability validation
 
-Total: 59 tests across 13 test files
+Total: 179 tests across 16 test files
 ```
 
 ## Search System Architecture

doc/README.md

@@ -26,7 +26,7 @@ Recent updates include direct streaming uploads and the ultra-compact search mod
 - Security architecture and defense-in-depth implementation
 - Performance characteristics and scalability considerations
 - Template system design and asset pipeline
-- Testing architecture with 106 comprehensive tests across 15 test files
+- Testing architecture with 125 comprehensive tests across 16 test files
 
 **Key Sections:**
 - Core module breakdown with line counts and responsibilities
@@ -91,7 +91,7 @@ Native zero-dependency template engine: variables, conditionals, embedded assets
 **Purpose**: Comprehensive testing suite documentation and validation procedures
 
 **Contents:**
-- **Complete Test Coverage**: 106 tests across 15 test files covering all functionality
+- **Complete Test Coverage**: 179 tests across 16 test files covering all functionality
 - **Test Categories**: Core server, integration, edge cases, memory optimization, performance, stress testing, streaming
 - **Security Testing**: Path traversal prevention, input validation, authentication mechanisms
 - **Performance Benchmarks**: Memory efficiency targets, upload speed thresholds, stress test metrics
@@ -339,7 +339,7 @@ IronDrop v2.5 introduces a **production-ready file upload system** with enterpri
 - **⚡ Performance**: Handles unlimited file sizes with constant memory usage and concurrent processing
 - **🎨 Professional UI**: Integrated upload interface accessible at `/upload` with real-time feedback
 - **🛡️ Robust Validation**: Multi-layer security including extension filtering, size limits, and malformed data rejection
-- **🧪 Battle-Tested**: 106 tests across 15 test files covering edge cases, security scenarios, and performance stress testing
+- **🧪 Battle-Tested**: 179 tests across 16 test files covering edge cases, security scenarios, and performance stress testing
 
 ### 🔍 **Advanced Search System** (New in v2.5)
 IronDrop v2.5 introduces a **dual-mode search engine** optimized for directories of any size:
@@ -625,7 +625,7 @@ Every module is documented and formatted with `cargo fmt` and `clippy -- -D warn
 
 ### Comprehensive Test Suite
 
-The project includes **106 comprehensive tests across 15 test files** covering all aspects of functionality, with complete upload system validation:
+The project includes **179 comprehensive tests across 16 test files** covering all aspects of functionality, with complete upload system validation:
 
 ```bash
 # Run all tests (covers upload, download, security, concurrency)
@@ -977,7 +977,7 @@ UI system and template integration:
 
 ### 🧪 **Testing & Quality Assurance**
 
-IronDrop includes **59 comprehensive tests across 13 test files** covering:
+IronDrop includes **179 comprehensive tests across 16 test files** covering:
 
 - **Core Server Tests** (19 tests): HTTP handling, directory listing, authentication
 - **Upload System Tests** (29 tests): File uploads, validation, concurrent handling
@@ -1005,7 +1005,7 @@ cargo test multipart_test       # Multipart parser
 | **Source Files** | 15 | Rust modules with clear separation of concerns |
 | **Lines of Code** | 3000+ | Production-ready implementation |
 | **Template Files** | 10 | Professional UI with HTML/CSS/JS separation |
-| **Test Cases** | 59 across 13 files | Comprehensive coverage including security tests |
+| **Test Cases** | 179 across 16 files | Comprehensive coverage including security tests |
 | **Documentation Pages** | 10 | Complete technical documentation suite |
 
 ---
@@ -1069,7 +1069,7 @@ We welcome contributions! Here's how to get started:
 
 ### **For Developers**
 - **Pure Rust**: No external dependencies, everything built from scratch
-- **Comprehensive Tests**: 59 tests across 13 files ensure reliability and stability
+- **Comprehensive Tests**: 179 tests across 16 files ensure reliability and stability
 - **Clean Architecture**: Well-documented, modular codebase
 - **Performance Focus**: Custom thread pool and optimized file streaming
 

doc/SEARCH_FEATURE.md

@@ -388,7 +388,7 @@ let engine = SearchEngine::new(
 
 ### Test Coverage
 
-The search functionality includes comprehensive tests as part of IronDrop's 59-test suite across 13 test files:
+The search functionality includes comprehensive tests as part of IronDrop's 125-test suite across 16 test files:
 
 1. **Ultra-Compact Search Tests** (`tests/ultra_compact_test.rs` - 4 tests):
    - RadixIndex memory efficiency with 10M entries

doc/TESTING_DOCUMENTATION.md

@@ -1,10 +1,10 @@
 # IronDrop Testing Documentation
 
-Version 2.6 - Test Suite Overview
+Version 2.6.2 - Test Suite Overview
 
 ## Overview
 
-IronDrop includes a test suite covering functionality, security scenarios, and performance-related paths.
+IronDrop includes a comprehensive test suite with **179 tests** covering functionality, security scenarios, performance validation, and concurrent operations. Recent improvements include enhanced path parsing, Unicode support, and race condition fixes.
 
 ## Test Architecture
 
@@ -22,17 +22,22 @@ IronDrop includes a test suite covering functionality, security scenarios, and p
 | Category | Test Files | Test Count | Coverage |
 |----------|------------|------------|----------|
 | **Core Server & Unit Tests** | `lib.rs` (unit tests) | 41 | Core functionality, HTTP handling, utilities |
-| **Configuration System** | `config_test.rs` | 12 | INI parsing, precedence, validation |
-| **Direct Upload System** | `direct_upload_test.rs` | 8 | File uploads, streaming, validation |
-| **Integration Testing** | `integration_test.rs` | 8 | Authentication, security, HTTP compliance |
-| **Monitoring & Stats** | `monitor_test.rs` | 2 | Health endpoints, metrics tracking |
-| **Rate Limiting** | `rate_limiter_memory_test.rs` | 5 | Memory management, cleanup, limits |
+| **Configuration System** | `config_test.rs` | 16 | INI parsing, precedence, validation, edge cases |
+| **Direct Upload System** | `direct_upload_test.rs` | 15 | File uploads, streaming, concurrent operations, race conditions |
+| **Integration Testing** | `integration_test.rs` | 14 | Authentication, security, HTTP compliance, edge cases |
+| **Memory & Performance** | `memory_leak_fix_test.rs` | 19 | Memory management, leak prevention, cleanup |
+| **HTTP Parser** | `http_parser_test.rs` | 13 | Version parsing, malformed requests, edge cases |
+| **Middleware** | `middleware_test.rs` | 13 | Authentication, security, request processing |
 | **Template System** | `template_embedding_test.rs`, `templates_escape_test.rs` | 7 | Embedded templates, escaping, assets |
+| **Template Utilities** | `response_utils_test.rs` | 2 | Response generation, template processing |
 | **Ultra-Compact Search** | `ultra_compact_test.rs` | 5 | Memory efficiency, search performance |
-| **Middleware** | `middleware_test.rs` | 5 | Basic auth middleware |
-| **HTTP Parser** | `http_parser_test.rs` | 3 | Version, separators, chunked handling |
+| **Rate Limiting** | `rate_limiter_memory_test.rs` | 5 | Memory management, cleanup, limits |
+| **Monitoring & Stats** | `monitor_test.rs` | 2 | Health endpoints, metrics tracking |
+| **Utilities** | `utils_test.rs`, `utils_parse_path_test.rs` | 23 | Path parsing, Unicode encoding, special characters |
 | **Request Body** | `http_requestbody_test.rs` | 1 | Size and emptiness |
-| **Utilities** | `utils_test.rs`, `utils_parse_path_test.rs` | 4 | Encoding, parsing, path utilities |
+| **Logging** | `log_dir_test.rs` | 3 | Directory creation, permissions |
+
+**Total Tests: 179**
 
 ## Detailed Test Coverage
 
@@ -177,7 +182,7 @@ fn test_demonstrate_memory_savings() // Compares memory usage vs alternatives
 
 ## Running Tests
 
-### Basic Test Execution (current totals: 106 tests across 15 files)
+### Basic Test Execution (current totals: 179 tests across 16 files)
 
 ```bash
 # Run all tests
@@ -367,6 +372,35 @@ fn test_new_feature() {
 - Code formatting validation
 - Documentation completeness
 
+## Recent Improvements (v2.6.2)
+
+### Critical Fixes and Enhancements
+
+**Path Parsing Improvements**
+- Fixed `get_request_path` function to correctly handle HTTP request paths with internal spaces
+- Enhanced logic to find space before "HTTP/" instead of using first space occurrence
+- Added proper whitespace trimming for edge cases with trailing spaces
+- All 9 path parsing tests now pass, including complex whitespace scenarios
+
+**Unicode and Special Character Support**
+- Enhanced `percent_encode_path` function with comprehensive character encoding
+- Added support for Unicode characters (non-ASCII) in file paths
+- Implemented proper handling of empty paths and root paths
+- Extended encoding for special characters requiring URL encoding
+- All 14 utility tests now pass with full Unicode compliance
+
+**Concurrent Upload Race Condition Fix**
+- Identified and resolved critical race condition in `generate_unique_filename` method
+- Replaced non-atomic file existence checks with atomic `create_new()` operations
+- Prevents multiple threads from creating files with same name simultaneously
+- All 15 direct upload tests now pass, including concurrent upload scenarios
+
+**Test Suite Stability**
+- Achieved 100% test pass rate across all 179 tests
+- Enhanced test reliability under concurrent execution
+- Improved error handling and edge case coverage
+- Added comprehensive validation for boundary conditions
+
 ## Future Test Enhancements
 
 ### Planned Additions

src/cli.rs

@@ -68,9 +68,9 @@ pub struct Cli {
     #[arg(long, value_parser = validate_config_file)]
     pub config_file: Option<String>,
 
-    /// Log file path - Redirect all logging output to a file instead of stdout. If not provided, logs go to stdout 📝
-    #[arg(long, value_parser = validate_log_file)]
-    pub log_file: Option<String>,
+    /// Log directory path - Directory where timestamped log files will be created. If not provided, logs go to stdout 📝
+    #[arg(long, value_parser = validate_log_dir)]
+    pub log_dir: Option<PathBuf>,
 }
 
 /// Validate upload size (minimum 1 MB, no upper limit for direct streaming)
@@ -112,54 +112,6 @@ fn validate_config_file(s: &str) -> Result<String, String> {
     }
 }
 
-/// Validate log file path and ensure parent directory exists
-fn validate_log_file(s: &str) -> Result<String, String> {
-    if s.is_empty() {
-        return Err("Log file path cannot be empty".to_string());
-    }
-
-    let path = PathBuf::from(s);
-
-    // Check if parent directory exists
-    if let Some(parent) = path.parent() {
-        if !parent.exists() {
-            return Err(format!(
-                "Log file parent directory does not exist: {}",
-                parent.display()
-            ));
-        }
-        if !parent.is_dir() {
-            return Err(format!(
-                "Log file parent path is not a directory: {}",
-                parent.display()
-            ));
-        }
-    }
-
-    // If file exists, check if it's writable
-    if path.exists() {
-        if path.is_dir() {
-            return Err(format!("Log file path is a directory: {s}"));
-        }
-        // Try to open for append to check write permissions
-        match std::fs::OpenOptions::new().append(true).open(&path) {
-            Ok(_) => {}
-            Err(e) => return Err(format!("Cannot write to log file {s}: {e}")),
-        }
-    } else {
-        // Try to create the file to check write permissions
-        match std::fs::File::create(&path) {
-            Ok(_) => {
-                // Remove the test file
-                let _ = std::fs::remove_file(&path);
-            }
-            Err(e) => return Err(format!("Cannot create log file {s}: {e}")),
-        }
-    }
-
-    Ok(s.to_string())
-}
-
 impl Cli {
     /// Validate the CLI configuration for security and consistency
     pub fn validate(&self) -> Result<(), AppError> {
@@ -243,7 +195,7 @@ mod tests {
             enable_upload: Some(false),
             max_upload_size: Some(100),
             config_file: None,
-            log_file: None,
+            log_dir: None,
         };
 
         // Test conversion
@@ -278,7 +230,7 @@ mod tests {
             enable_upload: Some(true),
             max_upload_size: Some(100),
             config_file: None,
-            log_file: None,
+            log_dir: None,
         };
 
         assert!(cli.validate().is_ok());
@@ -296,3 +248,40 @@ mod tests {
         assert!(file_cli.validate().is_err());
     }
 }
+
+/// Validate log directory path and ensure it exists and is writable
+fn validate_log_dir(s: &str) -> Result<PathBuf, String> {
+    if s.is_empty() {
+        return Err("Log directory path cannot be empty".to_string());
+    }
+
+    let path = PathBuf::from(s);
+
+    // Check if directory exists
+    if !path.exists() {
+        return Err(format!("Log directory does not exist: {}", path.display()));
+    }
+
+    // Check if it's a directory
+    if !path.is_dir() {
+        return Err(format!(
+            "Log directory path is not a directory: {}",
+            path.display()
+        ));
+    }
+
+    // Test write permissions by creating a temporary file
+    let test_file = path.join(".irondrop_write_test");
+    match std::fs::File::create(&test_file) {
+        Ok(_) => {
+            // Remove the test file
+            let _ = std::fs::remove_file(&test_file);
+            Ok(path)
+        }
+        Err(e) => Err(format!(
+            "Cannot write to log directory {}: {}",
+            path.display(),
+            e
+        )),
+    }
+}

src/config/ini_parser.rs

@@ -220,6 +220,10 @@ fn parse_file_size(value: &str) -> Option<u64> {
 
     // Try parsing as float for decimal values like "1.5"
     if let Ok(num) = num_str.parse::<f64>() {
+        // Reject negative numbers
+        if num < 0.0 {
+            return None;
+        }
         return Some((num * suffix as f64) as u64);
     }
 
@@ -249,6 +253,11 @@ mod tests {
             Some((2.5 * 1024.0 * 1024.0) as u64)
         );
         assert_eq!(parse_file_size("invalid"), None);
+
+        // Test invalid cases that should return None
+        assert_eq!(parse_file_size("-1MB"), None);
+        assert_eq!(parse_file_size("ABCMB"), None);
+        assert_eq!(parse_file_size("100XB"), None);
     }
 
     #[test]