Risky Time.Now() Usage

[Hellobloc]

Introduction

In this following code,the usage of time.Now in the key length is not a good practice for Non-determinism risk. In a wrong system time, the key length could be 30.

https://github.com/desmos-labs/desmos/blob/f6e7642a635cd0c0b7f6f2daf627c4aa11d924c9/x/posts/types/keys.go#L153C2-L153C54

Recommend Code

[-]var lenTime = len(sdk.FormatTimeBytes(time.Now()))
// The lenTime default is 29.
[+]var lenTime = 29

[Hellobloc]

@dadamu

[dadamu]

It becomes sdk.FormatTimeBytes, which uses the length of the SortableTimeFormat string, not the raw time bytes. As a result, the output is always in the form 2006-01-02T15:04:05.000000000.
https://github.com/cosmos/cosmos-sdk/blob/48d9ca4caf29cd48c8920fa66095840907af5421/types/utils.go#L67

[Hellobloc]

Although highly unlikely, when used for 10,000 years, this length grows to 30. I'm not sure if it's best practice to just use the default value as this length.

len(FormatTimeBytes(time.Date(10001, 7, 28, 0, 0, 0, 0, time.UTC)))