From b8b1b2f42d3dc40a16ebe4f67dbeb447dbf31ccc Mon Sep 17 00:00:00 2001 From: TrellixVulnTeam Date: Thu, 8 Dec 2022 21:15:37 +0000 Subject: [PATCH] Adding tarfile member sanitization to extractall() --- cargan/data/download.py | 24 +++++++++++++++++++++++- 1 file changed, 23 insertions(+), 1 deletion(-) diff --git a/cargan/data/download.py b/cargan/data/download.py index 7f12900..32aa9a5 100644 --- a/cargan/data/download.py +++ b/cargan/data/download.py @@ -91,7 +91,29 @@ def daps(): input_directory = cargan.DATA_DIR / 'daps' input_directory.mkdir(exist_ok=True, parents=True) with tarfile.open(file, 'r:gz') as tfile: - tfile.extractall(input_directory) + + import os + + def is_within_directory(directory, target): + + abs_directory = os.path.abspath(directory) + abs_target = os.path.abspath(target) + + prefix = os.path.commonprefix([abs_directory, abs_target]) + + return prefix == abs_directory + + def safe_extract(tar, path=".", members=None, *, numeric_owner=False): + + for member in tar.getmembers(): + member_path = os.path.join(path, member.name) + if not is_within_directory(path, member_path): + raise Exception("Attempted Path Traversal in Tar File") + + tar.extractall(path, members, numeric_owner=numeric_owner) + + + safe_extract(tfile, input_directory) # Get audio files audio_files = list(input_directory.rglob('*.wav'))