Skip to content

Commit e246b95

Browse files
authored
Simplify OIDC credential test parameter assertions (#109)
1 parent 3321b88 commit e246b95

1 file changed

Lines changed: 1 addition & 48 deletions

File tree

internal/oidc/oidc_credential_test.go

Lines changed: 1 addition & 48 deletions
Original file line numberDiff line numberDiff line change
@@ -386,54 +386,7 @@ func TestTryCreateOIDCCredential(t *testing.T) {
386386
assert.Equal(t, tc.expectedParameters.Name(), actual.Provider())
387387

388388
// check parameters
389-
switch p := actual.parameters.(type) {
390-
case *AWSOIDCParameters:
391-
expectedParams, ok := tc.expectedParameters.(*AWSOIDCParameters)
392-
if !ok {
393-
t.Fatalf("expected parameters of type AWSOIDCParameters, but got %T", tc.expectedParameters)
394-
}
395-
assert.Equal(t, expectedParams.Region, p.Region)
396-
assert.Equal(t, expectedParams.AccountID, p.AccountID)
397-
assert.Equal(t, expectedParams.RoleName, p.RoleName)
398-
assert.Equal(t, expectedParams.Audience, p.Audience)
399-
assert.Equal(t, expectedParams.Domain, p.Domain)
400-
assert.Equal(t, expectedParams.DomainOwner, p.DomainOwner)
401-
case *AzureOIDCParameters:
402-
expectedParams, ok := tc.expectedParameters.(*AzureOIDCParameters)
403-
if !ok {
404-
t.Fatalf("expected parameters of type AzureOIDCParameters, but got %T", tc.expectedParameters)
405-
}
406-
assert.Equal(t, expectedParams.TenantID, p.TenantID)
407-
assert.Equal(t, expectedParams.ClientID, p.ClientID)
408-
case *JFrogOIDCParameters:
409-
expectedParams, ok := tc.expectedParameters.(*JFrogOIDCParameters)
410-
if !ok {
411-
t.Fatalf("expected parameters of type JFrogOIDCParameters, but got %T", tc.expectedParameters)
412-
}
413-
assert.Equal(t, expectedParams.JFrogURL, p.JFrogURL)
414-
assert.Equal(t, expectedParams.ProviderName, p.ProviderName)
415-
assert.Equal(t, expectedParams.Audience, p.Audience)
416-
assert.Equal(t, expectedParams.IdentityMappingName, p.IdentityMappingName)
417-
case *CloudsmithOIDCParameters:
418-
expectedParams, ok := tc.expectedParameters.(*CloudsmithOIDCParameters)
419-
if !ok {
420-
t.Fatalf("expected parameters of type CloudsmithOIDCParameters, but got %T", tc.expectedParameters)
421-
}
422-
assert.Equal(t, expectedParams.OrgName, p.OrgName)
423-
assert.Equal(t, expectedParams.ServiceSlug, p.ServiceSlug)
424-
assert.Equal(t, expectedParams.ApiHost, p.ApiHost)
425-
assert.Equal(t, expectedParams.Audience, p.Audience)
426-
case *GCPOIDCParameters:
427-
expectedParams, ok := tc.expectedParameters.(*GCPOIDCParameters)
428-
if !ok {
429-
t.Fatalf("expected parameters of type GCPOIDCParameters, but got %T", tc.expectedParameters)
430-
}
431-
assert.Equal(t, expectedParams.WorkloadIdentityProvider, p.WorkloadIdentityProvider)
432-
assert.Equal(t, expectedParams.ServiceAccount, p.ServiceAccount)
433-
assert.Equal(t, expectedParams.Audience, p.Audience)
434-
default:
435-
t.Fatalf("unexpected parameters type %T", actual.parameters)
436-
}
389+
assert.Equal(t, tc.expectedParameters, actual.parameters)
437390
})
438391
}
439392
}

0 commit comments

Comments
 (0)