Skip to content

SetIndexedPropertyHandler is unsound/UB #2003

Description

@popematt

I discovered an (accidentally) unsound use of unsafe in SetIndexedPropertyHandler. The extern declaration doesn't match the actual signature of the v8 function. I've opened a PR to fix it (#1994), but I'm not sure if an unsolicited PR will get noticed (and you have no CONTRIBUTING.md file to suggest the proper way to engage about stuff like this).

I am currently using this method in my project, and I would like to get this UB fixed asap.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions