From a97f37cfb4714c267e4c47b7a6fb1eef308c3889 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Bartek=20Iwa=C5=84czuk?= Date: Mon, 1 Jun 2026 22:05:58 +0200 Subject: [PATCH] Revert "fix(core): disable include_icu_data feature (#34279)" Re-enable the include_icu_data feature by default so deno_core calls v8::icu::set_common_data with deno_core_icudata at startup again. This depends on rusty_v8 no longer embedding the ICU data blob into the V8 static library (denoland/rusty_v8#1999). With that change V8 uses an external ICU data file, so the embedder must supply the data at runtime; without this feature V8 boots with no ICU data and Intl/Temporal fail (the build-time snapshot generator aborts as well). --- libs/core/Cargo.toml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libs/core/Cargo.toml b/libs/core/Cargo.toml index 6e317a1d2daf45..62a7bae3f91e70 100644 --- a/libs/core/Cargo.toml +++ b/libs/core/Cargo.toml @@ -14,7 +14,7 @@ description = "A modern JavaScript/TypeScript runtime built with V8, Rust, and T path = "lib.rs" [features] -default = ["v8_use_custom_libcxx", "reactor-tokio"] +default = ["include_icu_data", "v8_use_custom_libcxx", "reactor-tokio"] reactor-tokio = [] include_icu_data = ["deno_core_icudata"] v8_use_custom_libcxx = ["v8/use_custom_libcxx"]