Standalone home-manager build failure after upgrade

[Sharparam]

After upgrading to v0.18.0 and reading through breaking changes and migration notes in the release notes, the standalone home-manager config still fails to build with nh home build:

> Building Home-Manager configuration
fetching git input 'git+file:///home/sharparam/repos/github.com/Sharparam/nix-config'
error:
       … while evaluating value
         at /nix/store/c4ymw711a6r51sgvazgk9kvy1r6cxqhy-source/lib/attrsets.nix:289:37:
          288|       len = length attrPath;
          289|       atDepth = n: if n == len then value else { ${elemAt attrPath n} = atDepth (n + 1); };
             |                                     ^
          290|     in

       … while evaluating module
         at /nix/store/gqsz0da47g4572vpsghhcrpz13gcn017-source/modules/default.nix:60:5:
           59|     in
           60|     module
             |     ^
           61|     // {

       (stack trace truncated; use '--show-trace' to show the full trace)

       error: An option declaration for `den.homes.x86_64-linux.sharparam@melina.contents' has type
       `list' rather than an attribute set.
       Did you mean to define this outside of `options'?
┏━ 1 Errors:
┃ error:
┃        … while evaluating value
┃          at /nix/store/c4ymw711a6r51sgvazgk9kvy1r6cxqhy-source/lib/attrsets.nix:289:37:
┃           288|       len = length attrPath;
┃           289|       atDepth = n: if n == len then value else { ${elemAt attrPath n} = atDepth (n + 1); };
┃              |                                     ^
┃           290|     in
┃
┃        … while evaluating module
┃          at /nix/store/gqsz0da47g4572vpsghhcrpz13gcn017-source/modules/default.nix:60:5:
┃            59|     in
┃            60|     module
┃              |     ^
┃            61|     // {
┃
┃        (stack trace truncated; use '--show-trace' to show the full trace)
┃
┃        error: An option declaration for `den.homes.x86_64-linux.sharparam@melina.contents' has type
┃        `list' rather than an attribute set.
┃        Did you mean to define this outside of `options'?
┣━━━
┗━ ∑ ⚠ Exited with 1 errors reported by nix at 18:13:29 after 0s
Error:
   0: Failed to build Home-Manager configuration
   1: Command exited with status ExitStatus(Exited(1))

Location:
   crates/nh-core/src/command.rs:1044

I haven't been able to figure this one out :/

Config is here: https://github.com/Sharparam/nix-config/tree/sharparam/push-zvmzmkvkwnpo

And the standalone home-manager config is here: https://github.com/Sharparam/nix-config/blob/sharparam/push-zvmzmkvkwnpo/modules/homes/sharparam%40melina/module.nix

Perhaps I've missed some detail in upgrading?

Output with --show-trace: https://gist.github.com/Sharparam/0358d94d82345b6b1f7a4cda9141ecf3

[sini]

I'll take a look today to see if I can diagnose it for you and if there's a regression related to den I'll put together a fix for it.

[Sharparam]

Downgrading to den v0.17.0 makes it build again, so definitely seems to be something that changed in v0.18.0.

[Sharparam]

Ok odd finding, but the issue seems to be with some options declarations here: https://github.com/Sharparam/nix-config/blob/main/modules/users/schema.nix

As can be seen in the current revision on that file, I commented the options and that made things work again. I'm not sure what the issue is with them though? Nix seems to complain that something is a list, but the options there produces an attrset as far as I can tell? (The result of the mkMerge)

cc @sini