fix: remove unreachable return 0 from CountJsonNodes and CountYamlNodes

Agent-Logs-Url: https://github.com/demaconsulting/FileAssert/sessions/4a6f09ef-6fd4-4d9c-b068-b24b93bc5890

Co-authored-by: Malcolmnixon <1863707+Malcolmnixon@users.noreply.github.com>

Author: Copilot

src/DemaConsulting.FileAssert/Modeling/FileAssertJsonAssert.cs

@@ -122,7 +122,8 @@ private static int CountJsonNodes(JsonElement root, string query)
         var segments = query.Split('.');
         var current = root;
 
-        for (var i = 0; i < segments.Length; i++)
+        // Traverse all but the last segment
+        for (var i = 0; i < segments.Length - 1; i++)
         {
             if (current.ValueKind != JsonValueKind.Object)
             {
@@ -135,18 +136,23 @@ private static int CountJsonNodes(JsonElement root, string query)
             }
 
             current = next;
+        }
 
-            if (i == segments.Length - 1)
-            {
-                // Return array length for arrays, or 1 for any other element
-                return current.ValueKind == JsonValueKind.Array
-                    ? current.GetArrayLength()
-                    : 1;
-            }
+        // Evaluate the final segment
+        if (current.ValueKind != JsonValueKind.Object)
+        {
+            return 0;
+        }
+
+        if (!current.TryGetProperty(segments[^1], out var leaf))
+        {
+            return 0;
         }
 
-        // Path traversal completed without reaching the final segment (empty segments list)
-        return 0;
+        // Return array length for arrays, or 1 for any other element
+        return leaf.ValueKind == JsonValueKind.Array
+            ? leaf.GetArrayLength()
+            : 1;
     }
 
     /// <summary>

src/DemaConsulting.FileAssert/Modeling/FileAssertYamlAssert.cs

@@ -129,7 +129,8 @@ private static int CountYamlNodes(YamlNode root, string query)
         var segments = query.Split('.');
         YamlNode? current = root;
 
-        for (var i = 0; i < segments.Length; i++)
+        // Traverse all but the last segment
+        for (var i = 0; i < segments.Length - 1; i++)
         {
             if (current is not YamlMappingNode mapping)
             {
@@ -140,22 +141,27 @@ private static int CountYamlNodes(YamlNode root, string query)
             {
                 return 0;
             }
+        }
 
-            if (i == segments.Length - 1)
-            {
-                // Return sequence length, or 1 for scalar/mapping nodes
-                return current switch
-                {
-                    YamlSequenceNode seq => seq.Children.Count,
-                    YamlScalarNode => 1,
-                    YamlMappingNode => 1,
-                    _ => 0
-                };
-            }
+        // Evaluate the final segment
+        if (current is not YamlMappingNode finalMapping)
+        {
+            return 0;
         }
 
-        // Path traversal completed without reaching the final segment (empty segments list)
-        return 0;
+        if (!finalMapping.Children.TryGetValue(new YamlScalarNode(segments[^1]), out var leaf))
+        {
+            return 0;
+        }
+
+        // Return sequence length, or 1 for scalar/mapping nodes
+        return leaf switch
+        {
+            YamlSequenceNode seq => seq.Children.Count,
+            YamlScalarNode => 1,
+            YamlMappingNode => 1,
+            _ => 0
+        };
     }
 
     /// <summary>