Skip to content

Regular Expression Parsing (non case insensitive) #77

@m1dst

Description

@m1dst

Hi,

By default, the string parsing for regular expressions is doing case insensitive checks by lowercasing the regex. Is there a reason for this? I am considering making changes to allow regex comparison to me made based on what you supply. EG: ^A\d{1,}.\d{1,}.1.\d{1,}$

If required I will create a pull request but before I do I want to ensure you are happy with the approach.

  • I could create a new property similar to _regex but call it _regexraw and then process accordingly.
  • I could just modify to not lowercase the string at all and let a user apply the /i to the end if they want it to be case insensitive.
  • Something else.

Personally, I think approach 2 (whilst breaking current functionality) is the most logical way forward.

Thoughts?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions