Skip to content

[BUG] Slicer prefix pins that don't end in '_' still false-fail at reconcile (follow-up to #1058) #1084

Description

@Defilan

PR #1082 (Fixes #1058) rejects trailing-underscore pins at plan-validation time, backstopping the reported rocm_smi_ case. But a prefix pin that stops on a letter/digit boundary (e.g. rocm_smi where the token stream is rocm_smi_sensor_temperature) is not detectable at plan-validation time without file content: it passes validation and still triggers the pinned-missing false-fail-and-skip at pkg/foreman/slicer/reconcile.go (present()), verbatim to #1058.

Proposed fix: extend PinnedCheck (which has the real file content) to detect when a failed pin is a strict prefix/substring of an in-file token and surface a distinct, actionable drift kind instead of a generic pinned-missing. Refs #1058, PR #1082.

Metadata

Metadata

Assignees

No one assigned

    Labels

    area/foremanForeman: the agentic fleet orchestrator add-onbugSomething isn't working

    Type

    No type

    Fields

    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions