Merge branch 'open-webui:dev' into dev

Author: deepmindru-afk

.github/pull_request_template.md

@@ -17,12 +17,14 @@ Link the maintainer's request for this PR, or state that the change is limited t
 
 ## Checklist
 
+- [ ] I have read and I understand the [contribution policy](https://docs.openwebui.com/contributing/#submit-code).
 - [ ] This PR targets the `dev` branch.
 - [ ] This PR links to a well-described, confirmed Issue or active Discussion: `Closes #___` / `Relates to #___`.
 - [ ] A maintainer explicitly asked me to open this PR, or this PR only updates i18n/localization.
 - [ ] The change is one logical unit with no unrelated commits.
 - [ ] I matched nearby code patterns and avoided unnecessary new settings, abstractions, or dependencies.
 - [ ] I manually tested the changed workflow and any nearby behavior that could be affected.
+- [ ] I have not added or rewritten automated tests, fixtures, snapshots, or testing infrastructure unless a maintainer explicitly requested them.
 - [ ] I updated relevant docs, including the [Open WebUI Docs Repository](https://github.com/open-webui/docs), if needed.
 - [ ] I added screenshots for UI changes, and a recording when motion or interaction matters.
 - [ ] I reviewed any AI-generated code before submitting it.
@@ -47,9 +49,11 @@ Use one of the following prefixes:
 
 Describe the change, the problem it solves, and the impact on users.
 
-## Testing
+## Verification
 
-List the exact manual checks you ran. Include commands, setup details, screenshots, or recordings where helpful.
+Describe how you reproduced the problem and manually checked the behavior before and after the change. Include exact steps, setup details, and relevant logs, screenshots, or recordings. Report results from relevant existing checks and anything you could not verify.
+
+Do not add or rewrite automated tests unless a maintainer explicitly requests them. Tests that repeat an implementation's assumptions can pass while preserving the same mistake; maintainers determine the regression coverage needed. Do not remove, disable, or weaken existing tests to make the change pass.
 
 ## Changelog Entry
 

backend/open_webui/env.py

@@ -1043,7 +1043,8 @@ def _parse_ssl_env(value: str) -> 'bool | _ssl.SSLContext':
 ENABLE_API_OUTLET_FILTERS = os.getenv('ENABLE_API_OUTLET_FILTERS', 'True').lower() == 'true'
 
 # Opt in to CPython's in-place string append optimization for streamed responses.
-# Disabled by default: allocation failure in the fast path can erase accumulated text.
+# Off by default for a staged rollout. Only a host already out of memory can lose
+# text here; the default path (a full copy per chunk) raises there too.
 ENABLE_CHAT_RESPONSE_STREAM_INPLACE_APPEND = os.getenv('ENABLE_CHAT_RESPONSE_STREAM_INPLACE_APPEND', 'False').lower() == 'true'
 
 # When enabled, uses a hardcoded extension-to-MIME dictionary as a last-resort

backend/open_webui/routers/openai.py

@@ -1417,8 +1417,8 @@ def convert_to_responses_payload(payload: dict) -> dict:
                         converted_tool['description'] = func['description']
                     if 'parameters' in func:
                         converted_tool['parameters'] = func['parameters']
-                    if 'strict' in func:
-                        converted_tool['strict'] = func['strict']
+                    # Responses defaults strict to true, Chat Completions to false
+                    converted_tool['strict'] = func.get('strict', False)
                 converted_tools.append(converted_tool)
             else:
                 # Already in correct format or unknown format, pass through

backend/open_webui/tools/knowledge_fs.py

@@ -7,11 +7,13 @@
 Re-exported through builtin.py for consistent imports.
 """
 
+import asyncio
 import contextvars
 import logging
 import re
 import shlex
 import time
+from collections.abc import Callable
 from contextlib import contextmanager
 from typing import Optional
 
@@ -727,6 +729,10 @@ async def _kb_tail(
     return result
 
 
+def _match_lines(content: str, matches: Callable[[str], bool]) -> list[tuple[int, str]]:
+    return [(i, line) for i, line in enumerate(content.split('\n'), 1) if matches(line)]
+
+
 async def _kb_grep(
     args: list[str], flags: set[str], user: dict, model_knowledge: list[dict] | None, piped_input: str | None = None
 ) -> str:
@@ -752,17 +758,14 @@ async def _kb_grep(
     count_only = 'c' in flags
     use_regex = 'E' in flags
 
-    _matches, err = build_matcher(pattern, case_insensitive, use_regex)
+    _matches, err = await asyncio.to_thread(build_matcher, pattern, case_insensitive, use_regex)
     if err:
         return err
 
     # Grep on piped input
     if piped_input is not None:
-        lines = piped_input.split('\n')
-        matched = []
-        for i, line in enumerate(lines, 1):
-            if _matches(line):
-                matched.append(f'{i}: {line}')
+        found = await asyncio.to_thread(_match_lines, piped_input, _matches)
+        matched = [f'{i}: {line}' for i, line in found]
         if count_only:
             return str(len(matched))
         if filenames_only:
@@ -778,11 +781,8 @@ async def _kb_grep(
         elif 'error' in resolved:
             return resolved['error']
         else:
-            lines = resolved['content'].split('\n')
-            matched = []
-            for i, line in enumerate(lines, 1):
-                if _matches(line):
-                    matched.append(f'{i}: {line}')
+            found = await asyncio.to_thread(_match_lines, resolved['content'], _matches)
+            matched = [f'{i}: {line}' for i, line in found]
 
             if count_only:
                 return f'{resolved["id"]}  {resolved["filename"]}: {len(matched)}'
@@ -833,11 +833,7 @@ async def _kb_grep(
         if not content:
             continue
 
-        lines = content.split('\n')
-        file_matches = []
-        for i, line in enumerate(lines, 1):
-            if _matches(line):
-                file_matches.append((i, line))
+        file_matches = await asyncio.to_thread(_match_lines, content, _matches)
 
         if file_matches:
             files_with_matches.append(file_info)

backend/open_webui/utils/middleware.py

@@ -324,7 +324,7 @@ def append_to_text_field(item: dict, key: str, value: str) -> None:
         return
 
     # Opt-in: dropping the dict's reference lets CPython extend an unshared str
-    # in place. An allocation failure can leave the field empty.
+    # in place. Only a host that is already out of memory can leave the field empty.
     text = item[key]
     item[key] = ''
     text += value
@@ -2888,7 +2888,8 @@ async def process_chat_payload(request, form_data, user, metadata, model):
     # that reject empty content blocks (e.g. AWS Bedrock ConverseStream).
     if not prompt or not prompt.strip():
         fallback = ', '.join([s.name for s in available_skills] + [s['name'] for s in terminal_skills])
-        if fallback:
+        # Attachment-only messages keep their empty text, same as on models without skills.
+        if fallback and not (metadata.get('user_message') or {}).get('files'):
             set_last_user_message_content(fallback, form_data['messages'])
             prompt = fallback
     # TODO: re-enable URL extraction from prompt