From b2067e6ae6fa3fc989cd0bae1d93b169033db107 Mon Sep 17 00:00:00 2001
From: Max Burian <burian.max@gmail.com>
Date: Wed, 19 Aug 2026 13:36:20 +0200
Subject: [PATCH] Add TSan and Helgrind CI jobs

---
 .github/workflows/main.yml | 53 ++++++++++++++++++++++++++++++++++++++
 1 file changed, 53 insertions(+)

diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml
index 17ad5be..eb0473b 100644
--- a/.github/workflows/main.yml
+++ b/.github/workflows/main.yml
@@ -105,3 +105,56 @@ jobs:
             ${{github.workspace}}.build/src/dectris/neggia/plugin/dectris-neggia.so
           if-no-files-found: error
           retention-days: 90
+
+  # Concurrency gates. Flags go via env, NOT -DCMAKE_*_FLAGS — a -D would
+  # silently drop the gtest -Wno-error accommodation.
+  tsan:
+    runs-on: ubuntu-24.04
+    env:
+      CXXFLAGS: -fsanitize=thread -g -Wno-error=maybe-uninitialized
+      CFLAGS: -fsanitize=thread -g
+      TSAN_OPTIONS: halt_on_error=1
+    steps:
+      - name: Checkout
+        uses: actions/checkout@v4
+        with:
+          submodules: true
+      - name: Create Build Directory
+        run: cmake -E make_directory ${{github.workspace}}.build
+      - name: Configure CMake (Release)
+        run: cmake ${{github.workspace}} -DCMAKE_BUILD_TYPE=Release -DDEBUG_PARSING=OFF -DCMAKE_POLICY_VERSION_MINIMUM=3.5
+        working-directory: ${{github.workspace}}.build
+      - name: Prove TSan instrumentation (fail if flags were lost)
+        run: grep -- '-fsanitize=thread' CMakeCache.txt
+        working-directory: ${{github.workspace}}.build
+      - name: Build
+        run: cmake --build .
+        working-directory: ${{github.workspace}}.build
+      - name: Test
+        run: ctest --output-on-failure
+        working-directory: ${{github.workspace}}.build
+
+  helgrind:
+    runs-on: ubuntu-24.04
+    env:
+      CXXFLAGS: -Wno-error=maybe-uninitialized
+    steps:
+      - name: Install valgrind
+        run: sudo apt-get update && sudo apt-get install -y valgrind
+      - name: Checkout
+        uses: actions/checkout@v4
+        with:
+          submodules: true
+      - name: Create Build Directory
+        run: cmake -E make_directory ${{github.workspace}}.build
+      - name: Configure CMake (Debug for symbolized Helgrind reports)
+        run: cmake ${{github.workspace}} -DCMAKE_BUILD_TYPE=Debug -DDEBUG_PARSING=OFF -DCMAKE_POLICY_VERSION_MINIMUM=3.5
+        working-directory: ${{github.workspace}}.build
+      - name: Build
+        run: cmake --build .
+        working-directory: ${{github.workspace}}.build
+      - name: Helgrind on concurrency tests (cwd = test dir for fixture symlink)
+        run: |
+          valgrind --tool=helgrind --error-exitcode=1 ./Test_XdsPluginConcurrent
+          valgrind --tool=helgrind --error-exitcode=1 ./Test_XdsPlugin
+        working-directory: ${{github.workspace}}.build/src/dectris/neggia/test