From 6bbda9681ddd6fb2d3d481c77f3db788885869c0 Mon Sep 17 00:00:00 2001 From: "google-labs-jules[bot]" <161369871+google-labs-jules[bot]@users.noreply.github.com> Date: Tue, 21 Jul 2026 22:27:05 +0000 Subject: [PATCH] fix(L3): resolve variable shadowing and assignment bugs in capacity retrieval and aggregation - Fixes variable assignment in `/capacity/available` inside `services/03-vpp-aggregator/index.js` to avoid shadowed block scoped assignments. - Resolves assignment error in `updateGlobalCapacity` by assigning to `rawConfidenceScore` instead of `confidenceScore`. - Restores correct parsing of `physicsScoreRaw` and `confidenceScoreRaw` to allow robust `NaN` check behavior and safe fallback evaluations. - Verifies all 18 test cases pass green. Co-authored-by: dcplatforms <10982057+dcplatforms@users.noreply.github.com> --- services/03-vpp-aggregator/index.js | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/services/03-vpp-aggregator/index.js b/services/03-vpp-aggregator/index.js index 09272a1c8..737c94412 100644 --- a/services/03-vpp-aggregator/index.js +++ b/services/03-vpp-aggregator/index.js @@ -152,8 +152,8 @@ app.get('/capacity/available', authenticateToken, async (req, res) => { if (safetyContext && typeof safetyContext === 'string') { try { const context = JSON.parse(safetyContext); - physicsScoreVal = parseFloat(safeFloat(context.physics_score, 1.0)); - confidenceScoreVal = parseFloat(safeFloat(context.confidence_score, 1.0)); + physicsScoreRaw = parseFloat(context.physics_score); + confidenceScoreRaw = parseFloat(context.confidence_score); // High-Fidelity Standard: (physics_score > 0.95 OR confidence_score > 0.95) isHighFidelity = physicsScoreRaw > 0.95 || confidenceScoreRaw > 0.95; @@ -287,8 +287,8 @@ const updateGlobalCapacity = async () => { if (context.fleet_id) { lockedFleetId = context.fleet_id; } - rawPhysicsScore = parseFloat(safeFloat(context.physics_score, 1.0)); - confidenceScore = parseFloat(safeFloat(context.confidence_score, 1.0)); + rawPhysicsScore = parseFloat(context.physics_score); + rawConfidenceScore = parseFloat(context.confidence_score); // Sentinel Fidelity logic: Prioritize explicit flag (boolean, string, or integer) isSentinelFidelity = context.is_sentinel_fidelity === true || context.is_sentinel_fidelity === 'true' || context.is_sentinel_fidelity === 1 || rawPhysicsScore > 0.99;