Set-DbaAgentOperator - Stop eating the caller loop on connection failure (#10653)

Author: andreasjordan

public/Set-DbaAgentOperator.ps1

@@ -296,7 +296,10 @@ function Set-DbaAgentOperator {
             try {
                 $InputObject += Get-DbaAgentOperator -SqlInstance $SqlInstance -SqlCredential $SqlCredential -Operator $Operator -EnableException
             } catch {
-                Stop-Function -Message "Failed" -Category ConnectionError -ErrorRecord $_ -Target $instance -Continue
+                # No -Continue here: this catch sits before the operator loop, so the continue would
+                # escape the command and eat an iteration of whatever loop the caller runs in.
+                Stop-Function -Message "Failed" -Category ConnectionError -ErrorRecord $_ -Target $instance
+                return
             }
         }
 

tests/Set-DbaAgentOperator.Tests.ps1

@@ -61,4 +61,35 @@ Describe $CommandName -Tag IntegrationTests {
             $results.EmailAddress | Should -Be "new@new.com"
         }
     }
+
+    Context "When the instance cannot be reached" {
+        BeforeAll {
+            # Lower the connection timeout so the three failing connection attempts stay fast.
+            $oldConnectionTimeout = Get-DbatoolsConfigValue -FullName sql.connection.timeout
+            $null = Set-DbatoolsConfig -FullName sql.connection.timeout -Value 2
+        }
+
+        AfterAll {
+            $null = Set-DbatoolsConfig -FullName sql.connection.timeout -Value $oldConnectionTimeout
+        }
+
+        It "Warns without eating an iteration of the caller's loop" {
+            # The connection catch used to run Stop-Function -Continue before the operator loop -
+            # the continue escaped the command and consumed an iteration of this very loop, so the
+            # counter fell short (#10638).
+            $loopCount = 0
+            foreach ($i in 1..3) {
+                $splatUnreachable = @{
+                    SqlInstance   = "dbatoolsci-nohost"
+                    Operator      = "dbatoolsci_nope"
+                    EmailAddress  = "nope@nope.com"
+                    WarningAction = "SilentlyContinue"
+                }
+                $null = Set-DbaAgentOperator @splatUnreachable
+                $loopCount++
+            }
+            $loopCount | Should -Be 3
+            ($WarnVar -join " ") | Should -BeLike "*Failed*"
+        }
+    }
 }