New-DbaAvailabilityGroup - Let the validation guards reach their own return (#10642)

Author: andreasjordan

public/New-DbaAvailabilityGroup.ps1

@@ -534,28 +534,30 @@ function New-DbaAvailabilityGroup {
         if (($SharedPath)) {
             if (-not (Test-DbaPath -SqlInstance $Primary -SqlCredential $PrimarySqlCredential -Path $SharedPath)) {
                 Write-Progress -Activity "Adding new availability group" -Completed
-                Stop-Function -Continue -Message "Cannot access $SharedPath from $Primary"
+                # No -Continue on these guards: no loop encloses them, so the continue escaped the
+                # command before the return below ever ran and ate an iteration of the caller's loop.
+                Stop-Function -Message "Cannot access $SharedPath from $Primary"
                 return
             }
         }
 
         if ($Database -and -not $UseLastBackup -and -not $SharedPath -and $Secondary -and $SeedingMode -ne 'Automatic') {
             Write-Progress -Activity "Adding new availability group" -Completed
-            Stop-Function -Continue -Message "You must specify a SharedPath when adding databases to a manually seeded availability group"
+            Stop-Function -Message "You must specify a SharedPath when adding databases to a manually seeded availability group"
             return
         }
 
         if ($server.HostPlatform -eq "Linux") {
             # New to SQL Server 2017 (14.x) is the introduction of a cluster type for AGs. For Linux, there are two valid values: External and None.
             if ($ClusterType -notin "External", "None") {
                 Write-Progress -Activity "Adding new availability group" -Completed
-                Stop-Function -Continue -Message "Linux only supports ClusterType of External or None"
+                Stop-Function -Message "Linux only supports ClusterType of External or None"
                 return
             }
             # Microsoft Distributed Transaction Coordinator (DTC) is not supported under Linux in SQL Server 2017
             if ($DtcSupport) {
                 Write-Progress -Activity "Adding new availability group" -Completed
-                Stop-Function -Continue -Message "Microsoft Distributed Transaction Coordinator (DTC) is not supported under Linux"
+                Stop-Function -Message "Microsoft Distributed Transaction Coordinator (DTC) is not supported under Linux"
                 return
             }
         }

tests/New-DbaAvailabilityGroup.Tests.ps1

@@ -102,6 +102,29 @@ Describe $CommandName -Tag IntegrationTests {
         $PSDefaultParameterValues.Remove("*-Dba*:EnableException")
     }
 
+    Context "When SharedPath is not accessible" {
+        It "Warns without eating an iteration of the caller's loop" {
+            # The validation guards used to run Stop-Function -Continue without an enclosing loop -
+            # the continue escaped the command before its own return statement ran and consumed an
+            # iteration of this very loop, so the counter fell short (#10638).
+            $loopCount = 0
+            foreach ($i in 1..3) {
+                $splatBadPath = @{
+                    Primary       = $TestConfig.InstanceHadr
+                    Name          = "dbatoolsci_agbadpath"
+                    ClusterType   = "None"
+                    FailoverMode  = "Manual"
+                    SharedPath    = "Q:\dbatoolsci\does\not\exist"
+                    WarningAction = "SilentlyContinue"
+                }
+                $null = New-DbaAvailabilityGroup @splatBadPath
+                $loopCount++
+            }
+            $loopCount | Should -Be 3
+            $WarnVar | Should -BeLike "*Cannot access*"
+        }
+    }
+
     Context "When creating availability groups" {
         It "returns an ag with a db named" {
             $splatAg = @{