diff --git a/libraries/tutorials/src/tutorial.ts b/libraries/tutorials/src/tutorial.ts index 8eb2c9cb37..3cf23d619d 100644 --- a/libraries/tutorials/src/tutorial.ts +++ b/libraries/tutorials/src/tutorial.ts @@ -124,7 +124,7 @@ export abstract class Tutorial extends DG.Widget { grok.shell.windows.showBrowse = true; } - async run(): Promise { + async start(): Promise { this._addHeader(); const tutorials = this.track?.tutorials; @@ -232,7 +232,7 @@ export abstract class Tutorial extends DG.Widget { this.clearRoot(); tutorialNode.html(''); tutorialNode.append(nextTutorial.root); - nextTutorial.run(); + nextTutorial.start(); }), ui.button('Cancel', () => { this.updateProgress(this.track); diff --git a/packages/Tutorials/CHANGELOG.md b/packages/Tutorials/CHANGELOG.md index 94bc7a33c4..c717e033e1 100644 --- a/packages/Tutorials/CHANGELOG.md +++ b/packages/Tutorials/CHANGELOG.md @@ -2,6 +2,7 @@ ## v.next +* Fixed the package build failing on `TS2416` — the u2 `Component` base introduced `run(fn)`, which every widget now inherits, so `Tutorial`'s own `run()` no longer matched; it is now `start()` * GROK-20602: BREAKING regen — `grok api` codegen v2 for the Northwind demo schema: datetime fields are dayjs, typed expand/transaction surface, lazy db.ts clients * Demo app: Added a Domain Databases demo (Data Access | Domain Databases) — ships the classic Northwind schema and data as a plugin-declared domain database (databases/northwind) and walks through browsing, security, audit history, and the JS API diff --git a/packages/Tutorials/src/tests/tutorial-test.ts b/packages/Tutorials/src/tests/tutorial-test.ts index a4e1073d48..24bd7efa69 100644 --- a/packages/Tutorials/src/tests/tutorial-test.ts +++ b/packages/Tutorials/src/tests/tutorial-test.ts @@ -29,7 +29,7 @@ category('Tutorials', () => { test('Run a tutorial', async () => { try { - await tutorial.run(); + await tutorial.start(); } catch (e) { expect(e instanceof Error ? e.message : e, 'Method "_run" not implemented.'); } diff --git a/packages/Tutorials/src/tutorial-runner.ts b/packages/Tutorials/src/tutorial-runner.ts index 925996644a..3a4a7991e0 100644 --- a/packages/Tutorials/src/tutorial-runner.ts +++ b/packages/Tutorials/src/tutorial-runner.ts @@ -19,7 +19,7 @@ export class TutorialRunner { $('#tutorial-child-node').html(''); $('#tutorial-child-node').append(t.root); t.clearRoot(); - await t.run(); + await t.start(); } async getCompleted(tutorials: Tutorial[]) {