Skip to content

Pack step does not run build script #41

Description

@matfire

Hey all,
love this package, it works really well, though I have a small issue.

I'm trying it on this repository (https://github.com/matfire/satteri-photoswipe) and everything works (staged publish, provenance checks etc), but the publish package does not actually contain the "dist" folder I would expect it to.

Looking through the different steps - particularly Pack - I noticed that nowhere in there is a call to a pnpm build or similar, and since the Publish step only retrieves the tarballs and publishes them afaik this releases packages that only have a package.json, a LiCENSE and a README.md.

For the package I mentioned above, running pnpm pack without a dist folder archives the following files:

  • LICENSE
  • package.json
  • README.md

Running pnpm pack with a dist folder, however, produces the following:

  • dist/index.d.mts
  • dist/index.mjs
  • LICENSE
  • package.json
  • README.md

Proposal

Add an optional argument to the pack action to run a script (i.e. pnpm build) if integrating it directly into the workflow could break existing workflows

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions