Hey all,
love this package, it works really well, though I have a small issue.
I'm trying it on this repository (https://github.com/matfire/satteri-photoswipe) and everything works (staged publish, provenance checks etc), but the publish package does not actually contain the "dist" folder I would expect it to.
Looking through the different steps - particularly Pack - I noticed that nowhere in there is a call to a pnpm build or similar, and since the Publish step only retrieves the tarballs and publishes them afaik this releases packages that only have a package.json, a LiCENSE and a README.md.
For the package I mentioned above, running pnpm pack without a dist folder archives the following files:
- LICENSE
- package.json
- README.md
Running pnpm pack with a dist folder, however, produces the following:
- dist/index.d.mts
- dist/index.mjs
- LICENSE
- package.json
- README.md
Proposal
Add an optional argument to the pack action to run a script (i.e. pnpm build) if integrating it directly into the workflow could break existing workflows
Hey all,
love this package, it works really well, though I have a small issue.
I'm trying it on this repository (https://github.com/matfire/satteri-photoswipe) and everything works (staged publish, provenance checks etc), but the publish package does not actually contain the "dist" folder I would expect it to.
Looking through the different steps - particularly
Pack- I noticed that nowhere in there is a call to apnpm buildor similar, and since thePublishstep only retrieves the tarballs and publishes them afaik this releases packages that only have apackage.json, aLiCENSEand aREADME.md.For the package I mentioned above, running
pnpm packwithout a dist folder archives the following files:Running
pnpm packwith a dist folder, however, produces the following:Proposal
Add an optional argument to the pack action to run a script (i.e. pnpm build) if integrating it directly into the workflow could break existing workflows