From 5499691c5ab6a30bd6d17df3f97570eb5f94f125 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Elan=20Ruusam=C3=A4e?= Date: Sun, 30 Jul 2023 16:55:16 +0300 Subject: [PATCH 1/2] Put long node error inside html details --- source/commands/utils/runDangerSubprocess.ts | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/source/commands/utils/runDangerSubprocess.ts b/source/commands/utils/runDangerSubprocess.ts index 65bb49b81..9c21fa7cd 100644 --- a/source/commands/utils/runDangerSubprocess.ts +++ b/source/commands/utils/runDangerSubprocess.ts @@ -127,7 +127,8 @@ export const runDangerSubprocess = ( d(`Handling fail from subprocess`) process.exitCode = code - const failResults = resultsWithFailure(`\`${processDisplayName}\` failed.`, "### Log\n\n" + markdownCode(allLogs)) + const moreMarkdown = "### Log\n\n
\n\n" + markdownCode(allLogs) + "\n\n
\n" + const failResults = resultsWithFailure(`\`${processDisplayName}\` failed.`, moreMarkdown) if (results) { results = mergeResults(results, failResults) } else { From 5855ac98f40edd427277a319221706e95e1d5d72 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Elan=20Ruusam=C3=A4e?= Date: Sun, 30 Jul 2023 17:02:26 +0300 Subject: [PATCH 2/2] Remove invalid "sh" syntax for node traces --- source/commands/utils/reporting.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/source/commands/utils/reporting.ts b/source/commands/utils/reporting.ts index 91f586f2f..b7ce65a29 100644 --- a/source/commands/utils/reporting.ts +++ b/source/commands/utils/reporting.ts @@ -1,7 +1,7 @@ import { DangerResults } from "../../dsl/DangerResults" export const markdownCode = (string: string): string => ` -\`\`\`sh +\`\`\` ${string} \`\`\` `