fix: normalize wizard tab names

Author: d0d1

src/codex_tabs/cli.py

@@ -43,6 +43,7 @@
     load_ignored_session_ids,
     load_registry,
     load_registry_data,
+    normalize_name,
     normalize_tags,
     validate_name,
     validate_session_id,
@@ -301,6 +302,7 @@ def main(argv: list[str] | None = None) -> int:
     "load_registry",
     "load_registry_data",
     "main",
+    "normalize_name",
     "normalize_tags",
     "open_named_sessions",
     "parse_saved_tab_selection",

src/codex_tabs/registry.py

@@ -1,6 +1,7 @@
 from __future__ import annotations
 
 import os
+import re
 from pathlib import Path
 
 import tomllib
@@ -108,10 +109,21 @@ def escape_toml(value: str) -> str:
     return value.replace("\\", "\\\\").replace('"', '\\"')
 
 
+def normalize_name(name: str) -> str:
+    normalized = name.strip().lower()
+    normalized = re.sub(r"\s+", "-", normalized)
+    normalized = re.sub(r"[^a-z0-9._-]+", "-", normalized)
+    normalized = re.sub(r"^[^a-z0-9]+", "", normalized)
+    normalized = re.sub(r"[^a-z0-9]+$", "", normalized)
+    normalized = re.sub(r"-{2,}", "-", normalized)
+    return normalized
+
+
 def validate_name(name: str) -> str:
-    if not NAME_RE.fullmatch(name):
-        raise ValueError("session names must match ^[a-z0-9][a-z0-9._-]*$")
-    return name
+    normalized = normalize_name(name)
+    if not NAME_RE.fullmatch(normalized):
+        raise ValueError("Choose a name that includes at least one letter or number.")
+    return normalized
 
 
 def validate_session_id(session_id: str) -> str:

src/codex_tabs/wizard.py

@@ -305,15 +305,17 @@ def process_selected_thread(
     print(header_text("Selected session:", stream=output), file=output)
     print_thread_details(thread, output=output)
     print("", file=output)
-    name = prompt_input(input_fn, "Name this tab (leave blank to cancel): ", output=output).strip()
-    if not name:
-        return
+    while True:
+        name = prompt_input(input_fn, "Name this tab (leave blank to cancel): ", output=output).strip()
+        if not name:
+            return
 
-    try:
-        validated_name = validate_name(name)
-    except ValueError as exc:
-        print(error_text(str(exc), stream=output), file=output)
-        return
+        try:
+            validated_name = validate_name(name)
+        except ValueError as exc:
+            print(error_text(str(exc), stream=output), file=output)
+            continue
+        break
 
     entries[validated_name] = SessionEntry(
         name=validated_name,

tests/test_validation.py

@@ -2,16 +2,22 @@
 
 import unittest
 
-from codex_tabs.cli import normalize_tags, validate_name, validate_session_id
+from codex_tabs.cli import normalize_name, normalize_tags, validate_name, validate_session_id
 
 
 class ValidationTests(unittest.TestCase):
     def test_validate_name_accepts_expected_format(self) -> None:
         self.assertEqual(validate_name("work.main"), "work.main")
 
-    def test_validate_name_rejects_invalid_format(self) -> None:
+    def test_validate_name_normalizes_common_input(self) -> None:
+        self.assertEqual(validate_name("Work Main"), "work-main")
+
+    def test_validate_name_rejects_non_names(self) -> None:
         with self.assertRaises(ValueError):
-            validate_name("Work Main")
+            validate_name("!!!")
+
+    def test_normalize_name_slugifies_friendly_input(self) -> None:
+        self.assertEqual(normalize_name(" Obsidian Notes "), "obsidian-notes")
 
     def test_validate_session_id_accepts_uuid_like_value(self) -> None:
         value = "01234567-89ab-cdef-0123-456789abcdef"

tests/test_wizard.py

@@ -18,6 +18,7 @@
     resolve_single_saved_tab_selection,
     run_wizard,
 )
+from codex_tabs.wizard import process_selected_thread
 
 
 class WizardTests(unittest.TestCase):
@@ -224,3 +225,36 @@ def test_browse_recent_threads_can_show_more(self) -> None:
 
         self.assertIsNotNone(selected)
         self.assertEqual(selected.session_id, threads_twenty[11].session_id)
+
+    def test_process_selected_thread_retries_invalid_name(self) -> None:
+        with tempfile.TemporaryDirectory() as tmp:
+            config = Path(tmp) / "sessions.toml"
+            output = io.StringIO()
+            responses = iter(["!!!", "Obsidian"])
+            thread = CodexThread(
+                session_id="01234567-89ab-cdef-0123-456789abcdef",
+                title="Thread",
+                cwd="/tmp/work",
+                created_at=1,
+                updated_at=2,
+                first_user_message="first",
+                last_user_message="last",
+                last_codex_message="assistant",
+            )
+
+            with patch("codex_tabs.wizard.prompt_yes_no", return_value=False):
+                entries: dict[str, SessionEntry] = {}
+                process_selected_thread(
+                    thread,
+                    entries,
+                    config,
+                    input_fn=lambda _prompt: next(responses),
+                    output=output,
+                )
+
+            self.assertIn("obsidian", entries)
+            self.assertEqual(entries["obsidian"].session_id, thread.session_id)
+            self.assertIn(
+                "Choose a name that includes at least one letter or number.",
+                output.getvalue(),
+            )