From 010f64daf42a4f06c32eb45e05bc2f048906f64e Mon Sep 17 00:00:00 2001 From: kellykang-tech Date: Sun, 24 Apr 2022 18:31:16 +0900 Subject: [PATCH] =?UTF-8?q?:memo:=20Add:=20=EC=A3=BC=EC=84=9D=20=EC=A0=95?= =?UTF-8?q?=EB=A6=AC?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- .../participation/service/ParticipationService.java | 4 ++-- .../io/cuki/domain/schedule/service/SchedulesService.java | 8 +------- 2 files changed, 3 insertions(+), 9 deletions(-) diff --git a/src/main/java/io/cuki/domain/participation/service/ParticipationService.java b/src/main/java/io/cuki/domain/participation/service/ParticipationService.java index 6bb92c5..b4496c0 100644 --- a/src/main/java/io/cuki/domain/participation/service/ParticipationService.java +++ b/src/main/java/io/cuki/domain/participation/service/ParticipationService.java @@ -88,7 +88,7 @@ public PermissionResponseDto updatePermission(PermissionRequestDto permissionReq PermissionResult result = permissionRequestDto.getAccept() ? PermissionResult.ACCEPT : PermissionResult.REJECT; log.debug("ParticipationService #updatePermission(): result = {}", result); participation.updateResult(result); - schedule.updateNumberOfPeopleWaiting(result); // + schedule.updateNumberOfPeopleWaiting(result); return PermissionResponseDto.of(participation); } @@ -106,7 +106,7 @@ public Set getWaitingList(Long scheduleId) { } - // 닉네임 매핑할 때 persistence 문제 생길텐데? -> 왜 안생기지? + public Set getParticipantList(Long scheduleId) { Set participantInfoResponseDtoSet = new HashSet<>(); diff --git a/src/main/java/io/cuki/domain/schedule/service/SchedulesService.java b/src/main/java/io/cuki/domain/schedule/service/SchedulesService.java index 58853d2..f970d37 100644 --- a/src/main/java/io/cuki/domain/schedule/service/SchedulesService.java +++ b/src/main/java/io/cuki/domain/schedule/service/SchedulesService.java @@ -25,10 +25,6 @@ @Service public class SchedulesService { - /** - * todo - * 스케쥴 관련 비즈니스 로직을 처리하는 곳에서 member 도메인의 repository 와 협력관계를 갖는 게 적절한가? 필요한 메서드는 id로 멤버를 찾아주는 기능뿐인데 - */ private final MemberRepository memberRepository; private final SchedulesRepository schedulesRepository; @@ -66,9 +62,7 @@ public SliceCustom getAllSchedule(int page, int size) { return new SliceCustom<>(dtoList, dtoSlice.hasNext(), dtoSlice.getNumber()); } - /** todo - * 스케쥴과 페이지를 만드는 메소드는 관계가 없다. srp 를 지키고 있지 않은 메소드 - */ + private PageRequest makePageRequest(int page, int size) { final Sort sort = Sort.by(Sort.Direction.DESC, "createdDate"); return PageRequest.of(page, size, sort);