Skip to content

Refactor ensemble-display-in-webamp styling: move positioning to CSS #324

Description

@magent-cryptograss

Current State

The #ensemble-display-in-webamp element has inline styles set via JS for positioning, with mobile/desktop branching logic.

Current inline styles:

  • position: relative/absolute (depends on mobile)
  • width: 100%/250px (depends on mobile)
  • marginTop: 10px (mobile only)
  • left: 0px (desktop only)
  • top: 130px (desktop only)
  • maxHeight: none
  • overflow: visible

Current CSS (.ensemble-display-in-webamp):

  • Only has background and color

Proposed Refactor

Move positioning styles to CSS with media queries:

  • Keep on element (JS): width, maxHeight, overflow
  • Move to CSS: position, top, left, padding, marginTop

This would:

  1. Separate concerns (layout in CSS, dynamic values in JS)
  2. Make styling easier to maintain
  3. Allow CSS-only adjustments for responsive breakpoints

Notes

  • Need to handle mobile vs desktop via CSS media queries
  • May also want to consolidate the .ensemble-grid removal (already done) cleanup

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Fields

    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions