Skip to content

Commit 574adde

Browse files
DavidCozensclaude
andcommitted
docs: say what the FatFs sector floor actually guards
The comment claimed a block below the sector size cannot back a coherent on-disk record layout. Nothing in Core depends on sector alignment or on a block write being atomic, and the adapter writes through byte-granular f_write, so what a sub-sector block costs is a read-modify-write per block. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
1 parent 842c434 commit 574adde

1 file changed

Lines changed: 5 additions & 5 deletions

File tree

Platform/FatFs/Source/SolidSyslogFatFsFile.c

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -15,11 +15,11 @@
1515
#include "SolidSyslogTunables.h"
1616
#include "ff.h"
1717

18-
/* The shared file-block-size default must clear one FatFs sector - a block
19-
* smaller than the underlying sector cannot back a coherent on-disk record
20-
* layout. FF_MAX_SS comes from the integrator's ffconf.h; guard with defined()
21-
* so the check is skipped (rather than evaluating an undefined identifier) on
22-
* any configuration that does not expose it. */
18+
/* The shared file-block-size default is held at or above one FatFs sector: a
19+
* block below the sector size makes every block write a sector
20+
* read-modify-write. FF_MAX_SS comes from the integrator's ffconf.h; guard with
21+
* defined() so the check is skipped (rather than evaluating an undefined
22+
* identifier) on any configuration that does not expose it. */
2323
#if defined(FF_MAX_SS) && (SOLIDSYSLOG_FILE_DEFAULT_BLOCK_SIZE < FF_MAX_SS)
2424
#error "SOLIDSYSLOG_FILE_DEFAULT_BLOCK_SIZE must be >= FF_MAX_SS (one FatFs sector)"
2525
#endif

0 commit comments

Comments
 (0)