Skip to content

Stale Angular reference: linked document doesn't define chore #680

Description

@nurse-the-code

Stale Angular reference: linked document doesn't define chore

Problem

The specification recommends commit types including chore:

"Additional types are not mandated by the Conventional Commits specification, and have no implicit effect in Semantic Versioning... Additional types are allowed, for example, @commitlint/config-conventional (based on the Angular convention) recommends build:, chore:, ci:, docs:, style:, refactor:, perf:, test:, and others."

The spec links to Angular's CONTRIBUTING.md at a specific commit:
https://github.com/angular/angular/blob/22b96b9/CONTRIBUTING.md#-commit-message-guidelines

However, this document does not define chore. It only lists: build, ci, docs, feat, fix, perf, refactor, style, and test.

The chore type actually comes from the older AngularJS project:
https://github.com/angular/angular.js/blob/master/DEVELOPERS.md

Where it's defined as: "Changes to the build process or auxiliary tools and libraries such as documentation generation"

Impact

Users following the spec who want to use chore (a commonly recommended type) cannot find its definition in the linked reference. This creates confusion about what chore means and when to use it.

Suggested Solutions

Define the types directly in the spec (see #634 for a related proposal), removing the dependency on external documentation that may change or become stale

Related Issues

Additional Context

The Angular project appears to have intentionally removed chore in favor of build for build-related changes. This divergence between the spec's recommendation and the linked reference suggests the external dependency model for type definitions is fragile.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions