Skip to content

Commit 57c3097

Browse files
Provision the e2e credentials so suites 4 and 5 stop skipping
conductor-oss serves secrets from the server process environment and rejects writes, so a suite that consumes a credential can only get one if it is set at boot. CI started the server bare, so suites 4 and 5 self-skipped their authenticated phases even though the behaviour they cover works there. Verified against the same configuration CI uses — bare 3.32.0-rc18, fresh DB, only these two variables set: 4 passed, 0 skipped (previously both suites skipped). Suites 2 and 3 still skip, and cannot be fixed this way: suite 2 sets and then updates a credential, and suite 3 removes one before adding it back, so both need a mutable store rather than a pre-provisioned value. Suite 3 additionally needs a real GITHUB_TOKEN.
1 parent 50045a9 commit 57c3097

1 file changed

Lines changed: 6 additions & 0 deletions

File tree

.github/workflows/agent-e2e.yml

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -85,6 +85,12 @@ jobs:
8585
exit 1
8686
8787
- name: Start server
88+
# conductor-oss serves secrets from the server process environment and
89+
# rejects writes, so suites that consume a credential need theirs
90+
# provisioned here or their authenticated phase self-skips.
91+
env:
92+
CONDUCTOR_SECRET_MCP_AUTH_KEY: e2e-test-secret-key-12345
93+
CONDUCTOR_SECRET_HTTP_AUTH_KEY: e2e-http-test-secret-key-67890
8894
run: |
8995
java -jar conductor-server.jar --server.port=8080 > server.log 2>&1 &
9096

0 commit comments

Comments
 (0)