Skip to content

Perk override UI allows negative values (Ropecon: -2 meal tickets) #1028

Description

@japsu

Reported by Ropecon 2026 in their post-con feedback: several program hosts ended up with exactly -2 meal tickets in their perks. Most likely user error, but the UI permits it.

The perk override number input (src/components/involvement/PerksForm.tsx, <input type="number">) has no min attribute and no clamping. A plausible mechanism for accidental changes: some browsers adjust a focused number input's value on mouse wheel scroll.

Fix:

  • min={0} on the number input and clamp on change.
  • Validate non-negative perk counts in the backend override mutation as well.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions