Skip to content

Commit fac1ef9

Browse files
committed
tests - certbot ec skey revocation working
certbot/certbot#8725
1 parent b7360e9 commit fac1ef9

1 file changed

Lines changed: 6 additions & 8 deletions

File tree

‎tests/test_ca.py‎

Lines changed: 6 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -616,7 +616,9 @@ async def test_certificate_content_type(self):
616616
class TestAcmeZ:
617617
def setUp(self) -> None:
618618
super().setUp()
619-
self.bin = str(Path("~/workspace/acmez/examples/porcelain/porcelain").expanduser())
619+
self.bin = str(
620+
Path("~/workspace/acmez/examples/porcelain/porcelain").expanduser()
621+
)
620622

621623
async def _run(self):
622624
cmd = self.bin
@@ -637,7 +639,6 @@ def llog(_line, logger):
637639
while r := await p.stdout.readline():
638640
llog(r, log.info)
639641

640-
641642
async def test_run(self):
642643
await self._run()
643644

@@ -787,9 +788,7 @@ class TestCertBotRSA2048EC256CA(TestCertBot, TestCA, unittest.IsolatedAsyncioTes
787788
CERT_KEY_ALG_BITS = ("EC", 256)
788789

789790
async def test_skey_revocation(self):
790-
# certbot 1.10.1 can do ec certificates but can not skey revoke them
791-
with self.assertRaises(AssertionError):
792-
await super().test_skey_revocation()
791+
await super().test_skey_revocation()
793792

794793

795794
class TestOurClientCA(TestOurClientStress, TestCA, unittest.IsolatedAsyncioTestCase):
@@ -806,7 +805,6 @@ async def test_keychange(self):
806805
await super().test_keychange()
807806

808807
async def no_test_mock_keychange(self):
809-
810808
keys = []
811809
for alg, abits in {"EC": (256, 521)}.items():
812810
for bits in abits:
@@ -823,7 +821,6 @@ async def no_test_mock_keychange(self):
823821
try:
824822
await self.client.key_change(kp)
825823
except acme.messages.Error:
826-
827824
self.client._make_request = m = unittest.mock.AsyncMock()
828825
m.return_value = (0, 0)
829826

@@ -985,5 +982,6 @@ def key_algo(self):
985982
class TestacmeshCA(Testacmesh, TestCA, unittest.IsolatedAsyncioTestCase):
986983
pass
987984

985+
988986
class TestAcmeZCA(TestAcmeZ, TestCA, unittest.IsolatedAsyncioTestCase):
989-
pass
987+
pass

0 commit comments

Comments
 (0)